Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent item duplication by updating processing recipes in SAG Mill #616

Merged
merged 3 commits into from Feb 15, 2024

Conversation

Lapis256
Copy link
Contributor

Description

In the SAG Mill's processing recipes, an incorrect BonusType was set, allowing for potential item duplication.
To resolve this issue, I have updated the recipes with the correct BonusType to prevent unauthorized item duplication.

Additionally, related to this change, two more fixes were implemented. First, I corrected an issue where grinding ball were mistakenly installed into the machine when starting a process with a BonusType of NONE without any grinding ball installed. Second, I have updated the display of JEI to hide grinding balls for recipes with a BonusType of NONE.

Closes #586

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@mystchonky mystchonky added Type-Bug There is a problem. MC-1.20.1 P-1-Medium Medium priority. Potentially deleting items or breaking functionality. labels Feb 13, 2024
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks a lot for contributing!

@Rover656 Rover656 merged commit 53b57fc into Team-EnderIO:dev/1.20.1 Feb 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MC-1.20.1 P-1-Medium Medium priority. Potentially deleting items or breaking functionality. Type-Bug There is a problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Duplication bug - unwanted extra output from grinding ball
3 participants