Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table headline #19

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Add table headline #19

merged 5 commits into from
Apr 3, 2023

Conversation

nehegeb
Copy link
Contributor

@nehegeb nehegeb commented Feb 28, 2023

Using just public string $headline = 'Table Headline'; within the corresponding DataTable.php one can add a headline directly to the table.

@nehegeb
Copy link
Contributor Author

nehegeb commented Mar 3, 2023

Btw.: I do not know what that "PHPStan / phpstan (push)" check is meant to do and why if would fail.

@nehegeb nehegeb self-assigned this Mar 6, 2023
@patrickweh
Copy link
Member

move the title to data-table-wrapper above the div that holds the table itself

<h1 class="text-base font-semibold leading-6 text-gray-900 dark:text-gray-50 pb-2.5"> {{ $headline }} </h1>

@nehegeb
Copy link
Contributor Author

nehegeb commented Apr 3, 2023

move the title to data-table-wrapper above the div that holds the table itself

I moved the headline above everything else.

@patrickweh patrickweh merged commit 06569ac into main Apr 3, 2023
10 of 11 checks passed
@patrickweh patrickweh deleted the add-table-headline branch April 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants