fix bugs #29
Merged
fix bugs #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor ModelInfo to only cash modelinfos for each model add Attribute.php class to get rid of deprecation warnings fix formatter for datetime to display the date AND the time (#26) add userOrderBy and userOrderAsc attribute. the default sort order defined using orderBy is not shown in the frontend anymore (#24) fix "no data" bug when changing perPage on the last page (#23)
refactor ModelInfo to only cash modelinfos for each model add Attribute.php class to get rid of deprecation warnings fix formatter for datetime to display the date AND the time (#26) add userOrderBy and userOrderAsc attribute. the default sort order defined using orderBy is not shown in the frontend anymore (#24) fix "no data" bug when changing perPage on the last page (#23)
This was
linked to
issues
Mar 28, 2023
SirSplasch
requested changes
Mar 28, 2023
| @@ -384,6 +384,8 @@ window.formatters = { | |||
| year: 'numeric', | |||
| month: '2-digit', | |||
| day: '2-digit', | |||
| hour: '2-digit', | |||
| minute: '2-digit', | |||
There was a problem hiding this comment.
Time formatter still not fixed (only time, without date)
SirSplasch
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix table footer
refactor ModelInfo to only cash modelinfos for each model
add Attribute.php class to get rid of deprecation warnings
fix formatter for datetime to display the date AND the time (#26)
add userOrderBy and userOrderAsc attribute.
the default sort order defined using orderBy is not shown in the frontend anymore (#24)
fix "no data" bug when changing perPage on the last page (#23)