#160[fix] 곰 미선택시 버튼 비활성화 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minemi00
approved these changes
Feb 7, 2024
| @@ -100,9 +100,9 @@ | |||
| android:layout_marginHorizontal="20dp" | |||
| android:layout_marginBottom="34dp" | |||
| style="?android:attr/borderlessButtonStyle" | |||
| android:background="@{viewModel.selectedBearType != @string/none ? @drawable/shape_main1_fill_12_rect : @drawable/shape_gray200_fill_12_rect}" | |||
| android:clickable="@{viewModel.selectedBearType != @string/none ? true : false}" | |||
There was a problem hiding this comment.
getString 써보자고 쓰려다가 후다닥 지웠습니다 ^^ ㅎ.ㅎ
emjayMJkim
approved these changes
Feb 7, 2024
Comment on lines
-103
to
-104
| android:background="@{viewModel.selectedBearType != @string/none ? @drawable/shape_main1_fill_12_rect : @drawable/shape_gray200_fill_12_rect}" | ||
| android:clickable="@{viewModel.selectedBearType != @string/none ? true : false}" |
There was a problem hiding this comment.
이 부분을 !viewModel.selectedBearType.equals(@string/none)로 바꾸면 될 것 같습니다..!
| @@ -6,7 +6,6 @@ | |||
| <string name="red">RED</string> | |||
| <string name="white">WHITE</string> | |||
| <string name="gray">GRAY</string> | |||
| <string name="none"></string> | |||
Comment on lines
15
to
22
| private val _selectedBearType: MutableLiveData<String> = MutableLiveData(NONE) | ||
| val selectedBearType: LiveData<String> get() = _selectedBearType | ||
| private val _isBearSelected: MutableLiveData<Boolean> = MutableLiveData(false) | ||
| val isBearSelected: LiveData<Boolean> get() = _isBearSelected | ||
|
|
||
| fun selectBearType(dollType: String) { | ||
| val isSameBearSelected = _selectedBearType.value == dollType | ||
|
|
||
| if (isSameBearSelected) _selectedBearType.value = NONE | ||
| else _selectedBearType.value = dollType |
There was a problem hiding this comment.
NONE으로 되어 있는 부분들 "NONE"으로 한번 바꿔서 해보실래요..?
pump9918
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
btn_unclickable.mp4
💬 To Reviewers
새 변수를 만들어주고 싶지 않은데, NONE인 경우만 자꾸 삼항 연산자가 안먹네요!!!!!!!!!!!!!!!!!! 이유 아시는 분 커피 한 잔