[ADD] 데일리 루틴 추가 예외처리 추가 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csb9427
approved these changes
Jan 13, 2024
Chan531
approved these changes
Jan 14, 2024
| return completedMemberDailyRoutineRepository.findByMemberAndRoutine(member, routine) | ||
| .map(completedRoutine -> recreateOldRoutines(member, routine, completedRoutine)) | ||
| .orElseGet(() -> createNewRoutine(member, routine)); | ||
| } | ||
|
|
||
| private void checkDuplicatedMemberRoutine(Member member, DailyRoutine routine) { | ||
| val isExistRoutine = memberDailyRoutineRepository.existsByMemberAndRoutine(member, routine); |
There was a problem hiding this comment.
여기 메서드 분리해서 if문안에 집어넣으면 더 깔끔할 거 같은데 어떻게 생각하시나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항
데일리 루틴 최대 3개 추가 가능, 중복된 루틴 추가 불가능 관련하여 예외 추가했습니다.
메소드명은 지피티에게 자문을 구했습니다.. 더 직관적인 메소드명이 떠오른다면 추천해주십쇼!
이 외에 더 좋은 코드 리팩토링이 떠오른다면 피드백 리뷰 언제나 환영입니다 :)