Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 행복 루틴 별 서브 행복 루틴 리스트 조회 api #112

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

Chan531
Copy link
Contributor

@Chan531 Chan531 commented Jan 15, 2024

✨ Related Issue

📝 기능 구현 명세

image

  • 조회 성공 시

image

  • 조회 오류 시

image

  • 스웨거 업데이트 확인

🐥 추가적인 언급 사항

구조가 복잡해서 메서드를 짜는데 시간이 꽤 걸렸습니다.
리뷰할 부분도 많을 거 같은데 천천히 봐주세요!

@Chan531 Chan531 added chan 찬 작업 feat 기능 개발 test 테스트 labels Jan 15, 2024
@Chan531 Chan531 self-assigned this Jan 15, 2024
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~
의논 또는 리뷰 반영 후 재언급 부탁드려요 :)

Comment on lines 32 to 34
public record HappinessSubRoutineResponse(

Long subRoutineId,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체크용입니다!

@Chan531 Chan531 changed the title Feature/#93 happiness routine list by theme [FEAT] 행복 루틴 별 서브 행복 루틴 리스트 조회 api Jan 15, 2024
Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 고생하셨습니다!

Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@Chan531 Chan531 merged commit bee376b into develop Jan 15, 2024
1 check passed
@Chan531 Chan531 deleted the feature/#93-happiness-routine-list-by-theme branch January 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chan 찬 작업 feat 기능 개발 test 테스트
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 행복루틴별 루틴 리스트 조회 api
3 participants