Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] 종합 이슈 처리 #113

Merged
merged 10 commits into from
Jan 16, 2024
Merged

Conversation

Chan531
Copy link
Contributor

@Chan531 Chan531 commented Jan 15, 2024

@Chan531 Chan531 added the chan 찬 작업 label Jan 15, 2024
@Chan531 Chan531 self-assigned this Jan 15, 2024
Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이슈 많이 처리하느라 고생하셨습니다!!

Comment on lines 76 to 87
.orElseThrow(() -> new EntityNotFoundException(INVALID_MEMBER.getMessage()));
}

private void checkMemberProfileExist(Member member) {
if (Objects.nonNull(member)) {
throw new IllegalStateException(EXIST_PROFILE.getMeesage());
throw new IllegalStateException(EXIST_PROFILE.getMessage());
}
}

private void checkMemberCottonCount(int cottonCount) {
if (cottonCount <= 0) {
throw new IllegalStateException(NOT_ENOUGH_COTTON.getMeesage());
throw new IllegalStateException(NOT_ENOUGH_COTTON.getMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

틀린 거 개많았는데 왜 눈치를 못챘을까

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인정 ㅋㅋㅋ

@@ -53,7 +53,7 @@ public void setMemberDoll(MemberDoll memberDoll) {
this.memberDoll = memberDoll;
}

public void initHappinessRoutine() {
public void resetHappinessRoutine() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이름 맘에 드는군요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

짱입니다~!
병합 전에 충돌만 확인 한 번 부탁드려요!

@Chan531 Chan531 merged commit b0f08f9 into develop Jan 16, 2024
1 check passed
@Chan531 Chan531 deleted the refactor/#-process-overall-issue branch January 16, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chan 찬 작업
Projects
None yet
3 participants