-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] 코드 스타일 통일 #124
[REFACTOR] 코드 스타일 통일 #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
진짜 수고많으셨습니다ㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체적으로 수정하시느라 너무 고생이 많았습니다 그런데 저희가 long을 사용하면서 메모리적인 부분도 개선이 된 형태일까요?? 아니면 처음 받는 건 Long이니까 메모리적인 부분에는 의미가 없는걸까요?
val memberHomeInfoResponse = memberService.getMemberHomeInfo(memberId); | ||
return ResponseEntity.ok(success(SUCCESS_HOME_INFO.getMessage(), memberHomeInfoResponse)); | ||
val response = memberService.getMemberHomeInfo(memberId); | ||
return ResponseEntity.ok(success(SUCCESS_HOME_INFO.getMessage(), response)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변수명을 변경한 이유가 있을까요?? 그저 궁금
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이슈 제목 그대로 통일성을 위한 것입니다!
.frameImageUrl("https://...") | ||
.dailyCottonCount(0) | ||
.happinessCottonCount(0) | ||
.conversations(List.of("안녕", "하이", "봉쥬르")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋ 3개 국어 ㄷㄷ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
찬이 작품 ㅋ.ㅋ
✨ Related Issue
📝 기능 구현 명세
none
🐥 추가적인 언급 사항