Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] 코드 스타일 통일 #124

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Conversation

thguss
Copy link
Member

@thguss thguss commented Jan 16, 2024

✨ Related Issue

📝 기능 구현 명세

none

🐥 추가적인 언급 사항

  • not null 추가 및 원시 타입 변경
  • response 이름 통일
  • Entity 내 All 생성자 가능한 제거

@thguss thguss added sohyeon 소현 작업 fix labels Jan 16, 2024
@thguss thguss requested a review from Chan531 January 16, 2024 10:54
@thguss thguss self-assigned this Jan 16, 2024
@thguss thguss requested a review from csb9427 January 16, 2024 10:54
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 수고많으셨습니다ㅠㅠ

Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 수정하시느라 너무 고생이 많았습니다 그런데 저희가 long을 사용하면서 메모리적인 부분도 개선이 된 형태일까요?? 아니면 처음 받는 건 Long이니까 메모리적인 부분에는 의미가 없는걸까요?

Comment on lines -56 to +55
val memberHomeInfoResponse = memberService.getMemberHomeInfo(memberId);
return ResponseEntity.ok(success(SUCCESS_HOME_INFO.getMessage(), memberHomeInfoResponse));
val response = memberService.getMemberHomeInfo(memberId);
return ResponseEntity.ok(success(SUCCESS_HOME_INFO.getMessage(), response));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수명을 변경한 이유가 있을까요?? 그저 궁금

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이슈 제목 그대로 통일성을 위한 것입니다!

.frameImageUrl("https://...")
.dailyCottonCount(0)
.happinessCottonCount(0)
.conversations(List.of("안녕", "하이", "봉쥬르"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋ 3개 국어 ㄷㄷ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

찬이 작품 ㅋ.ㅋ

@thguss thguss merged commit 6a37f5e into develop Jan 16, 2024
1 check passed
@thguss thguss deleted the refact/#89-code-style-refactor branch January 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix sohyeon 소현 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] null을 허용하지 않는 원시값을 쓰는 것에 대한 논의
3 participants