Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] 회원 행복루틴 조회, 204 분기 처리 추가 #130

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Jan 17, 2024

✨ Related Issue

📝 기능 구현 명세

image

🐥 추가적인 언급 사항

  • 행복 루틴 조회에서 데이터가 없을 경우를 고려하지 않아, 분기 처리를 추가했습니다.

@thguss thguss added add 작업 추가 sohyeon 소현 작업 labels Jan 17, 2024
@thguss thguss self-assigned this Jan 17, 2024
Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~~ 이런 오류 찾는 모습 멋져요..

Comment on lines -9 to +11
MemberHappinessRoutinesResponse getMemberHappinessRoutine(long memberId);
Optional<MemberHappinessRoutinesResponse> getMemberHappinessRoutine(long memberId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 궁금한게 이거 안바꾸고 null처리 된거를 사용해서도 가능했을 거 같은데 한 이유가 있나요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NullException의 위험성 때문에 최대한 null을 던지지 않기 위해 고민하다 결론 낸 방법이었어요!

Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다~
날카로운 캐치 좋습니다.
데일리 루틴에 대한 처리도 필요하겠네요ㅠㅠ

@thguss thguss merged commit e0fb979 into develop Jan 17, 2024
1 check passed
@thguss thguss deleted the add/#129-routine-exception-add branch January 17, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add 작업 추가 sohyeon 소현 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] 회원이 행복 루틴을 가지고 있지 않을 경우 예외 처리 추가
3 participants