[CHORE] 특정 값 변수 모음 클래스 병합 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chan531
approved these changes
Jan 29, 2024
| .orElseThrow(() -> new MemberException(INVALID_MEMBER)); | ||
| val token = generateAccessToken(new UserAuthentication(member.getId(), null, null)); | ||
| return TokenResponse.of(token); | ||
| } | ||
|
|
||
| private String getBearerToken(String token) { |
There was a problem hiding this comment.
메서드 뺀 거 좋은 거 같아요~
근데 "Bearer "를 뺀 나머지 string값을 받아오는 거라 메서드 이름을 바꿔야할 거 같긴한데... 어떻게 생각하시나요??
There was a problem hiding this comment.
지피티한테 자문 한 번 구해보겠습니당!!
그 외에 추천해주실 메소드명 있을까요??
There was a problem hiding this comment.
@Chan531 우선 "getTokenFromBearerString"으로 메소드 변경해서 병합해두겠습니다!
더 좋은 메소드명이 있다면 언제든 공유 부탁드려요~!
csb9427
approved these changes
Jan 30, 2024
Comment on lines
+98
to
+99
| val kid = ((JsonObject) JsonParser.parseString(header)).get(valueConfig.getKID_HEADER_KEY()); | ||
| val alg = ((JsonObject) JsonParser.parseString(header)).get(valueConfig.getALG_HEADER_KEY()); |
There was a problem hiding this comment.
뭔가 더 좋은 걸로 결론은 낫지만 코드가 길어진 거 같아 슬프긴 하군요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
none
🐥 추가적인 언급 사항