[FEAT] 회원 데일리 루틴 추가 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csb9427
approved these changes
Jan 10, 2024
@csb9427 기능 코드 작성 후 테스트 코드 나중에 짠 거 맞아요! 모든 작업 완료 후 커밋 순서를 임의로 하다보니 이렇게 된 것 같네요..! |
|
답변 감사합니당~~ 제가 모르는 심오한 뜻이 있을까 해서... ㅎㅎ |
Chan531
approved these changes
Jan 10, 2024
| public MemberDailyRoutineResponse createMemberDailyRoutine(long memberId, MemberDailyRoutineRequest request) { | ||
| val member = findMember(memberId); | ||
| val routine = findRoutine(request.routineId()); | ||
| val memberRoutine = new MemberDailyRoutine(member, routine); |
There was a problem hiding this comment.
member, routine에 findMember, findRoutine을 넣는 건 별로일까요?
| public ResponseEntity<Response> createMemberDailyRoutine( | ||
| Principal principal, @RequestBody MemberDailyRoutineRequest request) { | ||
| val memberId = Long.parseLong(principal.getName()); | ||
| val response = memberDailyRoutineService.createMemberDailyRoutine(memberId, request); |
There was a problem hiding this comment.
memberId에 Long.parseLong(principal.getName())을 넣는 건 별로일려나요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항