[ADD] 루틴 추가 중 예전 루틴 체크 로직 추가 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thguss
force-pushed
the
fix/#74-routine-fix-api
branch
from
68ae095
to
f3142f9
Compare
Chan531
approved these changes
Jan 11, 2024
| return memberDailyRoutineRepository.save(new MemberDailyRoutine(member, routine)); | ||
| } | ||
|
|
||
| private MemberDailyRoutine createOldRoutines( |
There was a problem hiding this comment.
이전 루틴을 가져온다는 부분에서 create보단 get같은 단어가 더 어울릴 거 같은데 혹시 어떻게 생각하시나요?
There was a problem hiding this comment.
저는 뭔가 create는 그대로 하는데 New를 사용하셨으니까 Old -> Prior은 어떠신지? 근데 Prior은 흐음.. 한 번 고민만 해주세요
There was a problem hiding this comment.
@csb9427 old로 사용하도록 하겠습니다! 좀 더 직관적이라는 것에 공감이 되었어요-!
There was a problem hiding this comment.
@Chan531 찾아보니 복구의 개념에 가까워서 create와 get보다는 re-가 더 직관적인 것 같아요! 가장 직관적으로 생각되는 recreate로 반영하도록 할게요!
csb9427
approved these changes
Jan 11, 2024
| return memberDailyRoutineRepository.save(new MemberDailyRoutine(member, routine)); | ||
| } | ||
|
|
||
| private MemberDailyRoutine createOldRoutines( |
There was a problem hiding this comment.
저는 뭔가 create는 그대로 하는데 New를 사용하셨으니까 Old -> Prior은 어떠신지? 근데 Prior은 흐음.. 한 번 고민만 해주세요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항
리팩토링.. 머리 감싸면서 쥐어짜냈는데 더 좋은 코드가 떠오르지 않네용.. 🥺
좀 더 좋은 리팩토링 방식이 있다면.. 훈수 제안 언제나 환영입니다 ㅎㅁㅎ