feat: 모집의뢰서 수정 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8287aeb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd650238.jobis-company.pages.dev |
| Branch Preview URL: | https://feature-5-edit-recruitments.jobis-company.pages.dev |
KANGYONGSU23
reviewed
Nov 3, 2023
| @@ -81,6 +81,7 @@ export default function SignIn() { | |||
| placeholder="사업자 번호를 입력해주세요" | |||
| maxLength={12} | |||
| onChange={onChange} | |||
| autoComplete="off" | |||
There was a problem hiding this comment.
그 인풋에서 밑에 auto complete를 삭제하는 건데
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete 이 자료 참고해보시면 됩니다.
기본값은 on이 맞습니다
| @@ -38,7 +38,7 @@ const EditRecruitArea = ({ setForm }: IPropsType) => { | |||
| job_codes: area.job_codes, | |||
| }); | |||
| } | |||
| }, [myRecruitment]); | |||
| }, [myRecruitment, area.id, area.hiring, area.job_codes, area.major_task, area.tech_codes, setArea]); | |||
There was a problem hiding this comment.
이거 하니까 문제가 생겨서 다시 복구했습니다
| @@ -23,20 +23,20 @@ export const Spinner = ({ size = 180, position, isMessage }: LoadingProps) => { | |||
| }, [message]); | |||
|
|
|||
| return ( | |||
| <_Wrapper pos={position ?? "center"}> | |||
| <_Wrapper $pos={position ?? "center"}> | |||
There was a problem hiding this comment.
$는 styled components전용이라는걸 표기해주는 건가요?
There was a problem hiding this comment.
이게 이렇게 안하니까 경고가 뜨더라구요.
이 이미지 에러가 계속 떠서 일단 얘만 실험으로 안뜨는지 확인한다고 사용하였습니다
styled-components/styled-components#4071
이 에러와 동일한 거 같네요
There was a problem hiding this comment.
transient props 검색해보시면 됩니다.
간단히 말해서 props로써 값 결정하는 데에만 쓰이고 실제 dom에는 적용되지 않게 됩니다.
때문에 지관이가 말한 저 에러 또한 잡히는 겁니다.
JJIIIINN
reviewed
Nov 3, 2023
| } | ||
| }, [myRecruitment, setForm]); | ||
|
|
||
| if (isLoading) { |
There was a problem hiding this comment.
p1) 이 코드 페이지마다 계속 나오는 것 같은데 suspense 써보는 건 어떨까요?
jikwan0327
force-pushed
the
feature/5-edit_recruitments
branch
from
3a6646a
to
8287aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5