Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔗 :: (#48) XCConfig 설정 #89

Merged
merged 29 commits into from
Dec 21, 2023
Merged

🔗 :: (#48) XCConfig 설정 #89

merged 29 commits into from
Dec 21, 2023

Conversation

HongSJae
Copy link
Member

@HongSJae HongSJae commented Dec 17, 2023 •
edited
Loading

개요

XCConfig 설정

작업사항

  • XCConfig 설정
  • CI도 Xcode Cloud로 변경
  • Template 설정
  • Presentation Resources -> DesignSystem Resources
  • Base URL -> API Base URL, S3 Base URL

UI

스크린샷 2023-12-17 오후 4 55 04

@HongSJae
📝 :: gitignore 에 XCConfig 추가
47d00ad
@HongSJae
🧩 :: ConfigurationPlugin 추가
4e69aab
@HongSJae
🧩 :: App/Tests 추가
dc222b2
@HongSJae
🧩 :: Project Template 수정
f280164
@HongSJae
🛠️ :: Presentation에 있는 Resource 모두 DesignSystem으로 이동
76e6bc0
@HongSJae
🧩 :: OnboardingImage
c6a2b12
@HongSJae
🧩 :: JobisLottieView
1bb998d
@HongSJae
🛠️ :: 복수명사로 변수명 수정
06b8146
@HongSJae
🧩 :: Plugins 에 ConfigurationPlugin 추가
ab2fbf3
@HongSJae
🧩 :: OnboardingVC Designsystem 사용
e2e0eb4
@HongSJae
🧩 :: Presentation Resources 제거
1b373eb
@HongSJae
🧩 :: entitlements
c93a89b
@HongSJae
🛠️ :: JwtPlugin init 넣어주기
5abe577
@HongSJae
🛠️ :: staticLibarary
31c8cce
@HongSJae
🧩 :: Info.plist 수정
7b43dc6
@HongSJae
Revert "🧩 :: Info.plist 수정"
15b55f3 
This reverts commit 1862d71.
@HongSJae
🧩 :: Info.plist 환경 변수 설정
7414d5f
@HongSJae
🧩 :: Project Template
d1055d5
@HongSJae
🛠️ :: Lib Dependency baseSetting
a2ce4d2
@HongSJae
🧩 :: Sources/Resources Template
06f70f6
@HongSJae
🧩 :: DesignSystem Demo 추가
b5a5707
@HongSJae
🧩 :: Presentation/AppNetwork/Flow/Domain/Data TargetTest 추가
21437b3
@HongSJae
🧩 :: CodeSign 추가
1170bed
@HongSJae
🧩 :: Product Project.swift 파일 수정
39958c8
@HongSJae
🛠️ :: Path XCConfig 파일 return 지움
f23acc2
@HongSJae
🛠️ :: BASE_URL -> API_BASE_URL
b9de78c
@HongSJae
🧩 :: Graph update
668134a
@HongSJae
♻️ :: CI Scripts 수정
c296a82
@HongSJae HongSJae added the ✨feat 새로운 기능을 추가 할 경우 label Dec 17, 2023
@HongSJae HongSJae self-assigned this Dec 17, 2023
@HongSJae HongSJae linked an issue Dec 17, 2023 that may be closed by this pull request
XCConfig 설정 #48
Closed
juyeong525
juyeong525 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@juyeong525 juyeong525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿

@HongSJae HongSJae merged commit b1d1528 into develop Dec 21, 2023
@HongSJae HongSJae deleted the feature/(#48)-xcconfig_setting branch December 21, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juyeong525 juyeong525 juyeong525 approved these changes

@ray3238 ray3238 ray3238 approved these changes

Assignees

@HongSJae HongSJae

Labels
✨feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCConfig 설정
3 participants
@HongSJae @juyeong525 @ray3238