Make Stream covariant to match regular collections #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the weird typing issues we encountered earlier, such as not being able to view a stream of `None`s as a stream of `Option`s.
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 58.84% 58.84%
=======================================
Files 68 68
Lines 1329 1329
Branches 123 123
=======================================
Hits 782 782
Misses 547 547
Continue to review full report at Codecov.
|
|
Ping @paxelord for review |
PhilipAxelrod
pushed a commit
that referenced
this pull request
Dec 7, 2017
* Make Stream covariant to match regular collections This should fix the weird typing issues we encountered earlier, such as not being able to view a stream of `None`s as a stream of `Option`s. * Remove unused `Value` type member * Add unit test for covariant behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the weird typing issues we encountered earlier, such as not being able to view a stream of
Nones as a stream ofOptions.