Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IMU communications implementation #61

Closed
wants to merge 1 commit into from
Closed

Conversation

shadaj
Copy link
Contributor

@shadaj shadaj commented Feb 17, 2017

No description provided.

@codecov
Copy link

codecov bot commented Feb 17, 2017

Codecov Report

Merging #61 into master will increase coverage by 0.7%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master      #61     +/-   ##
=========================================
+ Coverage   53.99%   54.69%   +0.7%     
=========================================
  Files          52       52             
  Lines         776      766     -10     
  Branches       65       65             
=========================================
  Hits          419      419             
+ Misses        357      347     -10
Impacted Files Coverage Δ
...nbrookrobotics/potassium/sensors/imu/Value3D.scala 66.66% <ø> (ø)
...rookrobotics/potassium/sensors/imu/ADIS16448.scala 0% <ø> (ø)
...com/lynbrookrobotics/potassium/frc/Implicits.scala 13.33% <ø> (ø)
...la/com/lynbrookrobotics/potassium/frc/RioSPI.scala 0% <ø> (ø)
...okrobotics/potassium/sensors/imu/IMURegister.scala 0% <ø> (ø)
...okrobotics/potassium/sensors/imu/DigitalGyro.scala 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8c016...97d2f3e. Read the comment docs.

@PhilipAxelrod
Copy link
Contributor

Unfortunately, Nikash made a mistake with his original PR, (which is now merged), and the code currently in potassium does not work. This will have to wait until he sorts this out ):

Copy link
Contributor

@PhilipAxelrod PhilipAxelrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until Nikash makes a new imu PR fixing merge issues

@shadaj shadaj closed this Feb 28, 2017
@shadaj shadaj deleted the imu-refactor branch March 12, 2017 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants