Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make number of tabs configurable #1956

Closed
macearl opened this issue Aug 12, 2020 · 8 comments
Closed

Feature Request: Make number of tabs configurable #1956

macearl opened this issue Aug 12, 2020 · 8 comments
Labels
Issue-Feature A feature request or improvement.

Comments

@macearl
Copy link

macearl commented Aug 12, 2020

Description

I often switch between 3 or 4 different storage devices / directories and would like to have a separate tab for each of them.

With amaze right now I could bookmark each of these paths and switch between them that way however I think a simple swipe left or right or picking a tab from an always showing tab bar would be so much more comfortable

I'm currently also using root explorer just for this feature. However as I generally like amaze more and would like to migrate everything to open source apps it would be nice if more than 2 tabs would be possible.

Keep up the good work!

@macearl macearl changed the title Make number of tabs configurable Feature Request: Make number of tabs configurable Aug 12, 2020
@EmmanuelMess
Copy link
Member

This requires some refactoring of the ways tabs is done, but shouldn't be too difficult

@VishalNehra
Copy link
Member

We had initial few releases where we did implement this dynamic tabs approach. But for most people they don't use that many tabs, and for a simplistic design, we removed it later on. Maybe I'll attach the apk for those release and you can give it a shot. If you like we might give it a shot.

@macearl
Copy link
Author

macearl commented Aug 14, 2020

We had initial few releases where we did implement this dynamic tabs approach. But for most people they don't use that many tabs, and for a simplistic design, we removed it later on. Maybe I'll attach the apk for those release and you can give it a shot. If you like we might give it a shot.

Sure I'd like to give the old version a go. It would probably be easier to reimplement that code instead of completely rewriting it

@VishalNehra
Copy link
Member

#2744

@EmmanuelMess
Copy link
Member

@VishalNehra the two issues are not the same thing.

@EmmanuelMess EmmanuelMess reopened this Nov 13, 2021
@VishalNehra
Copy link
Member

It's by design choice we keep two tabs, left and right. Regardless of the number of devices currently connected. If we want more tabs we can open more windows as pointed in #2744

@EmmanuelMess
Copy link
Member

It's by design choice we keep two tabs, left and right. Regardless of the number of devices currently connected. If we want more tabs we can open more windows as pointed in #2744

IMO a design discussion should be opened to use another system, unifying the TextEditor taks and tabs.

@EmmanuelMess
Copy link
Member

See #3023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature A feature request or improvement.
Projects
None yet
Development

No branches or pull requests

3 participants