Feature/0971 implement trash bin #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishnuSanal
reviewed
Nov 1, 2023
…y icon in trash bin
In most file manager implementations, including desktop ones, remote files are to be deleted directly even when put to recycle bin.
Also a condition inside DeleteTask, that delete SSH files should not trigger mediascanner as well.
|
@VishalNehra Fixed test failures in 8dbfaec and Codacy complaints on missing Javadoc in bd77530. There should be no option to allow user to put remote files (SMB/SSH/etc) to trash bin, and as I checked (Pixel 2 emulator running SDK 28), this had been covered in the UI level. |
|
Is there a way to disable the trash bin? I couldn't find a setting. Not sure if using 0 for file # limit works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue tracker
Fixes #971
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck