Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for L2 overflow #344

Open
ilyamandel opened this issue Aug 29, 2020 · 0 comments
Open

Check for L2 overflow #344

ilyamandel opened this issue Aug 29, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers severity_minor This bug is not very severe urgency_low This issue is not urgent

Comments

@ilyamandel
Copy link
Collaborator

ilyamandel commented Aug 29, 2020

Currently, we check whether stars are touching (e.g., left touching by an MT episode), and use this as a proxy for merger. This check resolves to a check for whether the sum of the stellar radii exceeds the semi-major axis:

BaseBinaryStar.h: bool HasStarsTouching() const { return (utils::Compare(m_SemiMajorAxis, 0.0) > 0) && (m_SemiMajorAxis <= RSOL_TO_AU * (m_Star1->Radius() + m_Star2->Radius())); }

A more realistic check would consider whether stars engage in L2 overflow. The two are equivalent for equal-mass stars in a circular binary, so the current check is not a terrible proxy, but we should improve this.

P.S. Should also address the initial check in the constructor of BaseBinaryStar (see #309 ).

@ilyamandel ilyamandel added enhancement New feature or request severity_minor This bug is not very severe urgency_low This issue is not urgent labels Aug 29, 2020
@ilyamandel ilyamandel added the good first issue Good for newcomers label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers severity_minor This bug is not very severe urgency_low This issue is not urgent
Projects
None yet
Development

No branches or pull requests

1 participant