Migration of Error Discussion to Collab Platform #2171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinAllen
force-pushed
the
feature/collab-errors-discussions
branch
4 times, most recently
from
5afb745
to
ec6e73f
Compare
CalvinAllen
force-pushed
the
feature/collab-errors-discussions
branch
3 times, most recently
from
5413e52
to
61ec4af
Compare
…t where there is no previous thread.
…om the context (of if none, the one we create)
…"most recent thread"
… create a new comment against a thread.
… and "Stream" has been removed / commented out and how they (used to) apply to Code Errors.
… refactors, file moves, etc. Timing issues exist when opening an error and getting the stack trace + click event to work properly. Next time.
Issues: 1. Initial load does not "click" the first user code line available. (does the second time...dumb timing)
… to collab provider.
…sily regenerate the hash/context if needed using those two props. Adding doc comments and cleanup.
…tions popup. Starting to tie it FROM CS Users to NR Users.
…e the thread with NRAI
…Name to repoInfo to include the url so we can fake a permalink
…r querying for comments
…in NRAI call. Add a bunch of comments, and remove the ability to edit or delete a comment (because they don't always work)
CalvinAllen
force-pushed
the
feature/collab-errors-discussions
branch
from
8356aae
to
4a9219c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much a WIP!