Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create executable and do version checking #7

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Conversation

akshualy
Copy link
Contributor

Resolves #6

Code changes:

  • Adds pyinstaller to create a windows binary, including an icon file
  • Adds file resolving, since pyinstaller creates files in a different location
  • Adds a function to compare two semantic versions
    • Used to compare the Play Store with the emulator TFT version
    • Used to compare remote bot version with the local one
  • Renames the optional dependency group 'lint' to 'dev' - Install now needs to be done with pip install .[dev]
  • Creates a logger sink to a new logs folder, up to 10 most recent logs are being kept there

Since we now keep logs, I decided against a "Press any key to continue" catch in the console. It was not as reliable as I wanted it to be.

Workflow changes:

  • Adds a 'build' workflow to build the executable
    • Comes with a release workflow which needs to be triggered manually on main
    • The release workflow grabs the version from the pyproject.toml version field
  • Renamed the 'main' workflow to 'lint' and now runs on ubuntu

README changes:

  • Now distinguishes between executable and source for setup and running
  • Adds a section about how to compile
  • Changes the 'Lint' badge to the 'Build' badge

@akshualy akshualy added the enhancement New feature or request label Apr 25, 2024
@akshualy akshualy self-assigned this Apr 25, 2024
Copy link
Contributor

@Kyrluckechuck Kyrluckechuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Happy to see all that boilerplate and debugging done on the previous bot can be carried on here, though you added some much cleaner improvements 👌

Alune.spec Show resolved Hide resolved
Alune.spec Show resolved Hide resolved
Copy link
Contributor

@Detergent13 Detergent13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the bot changes, although I'm probably not qualified to comment on the CI portion.

@akshualy
Copy link
Contributor Author

akshualy commented Apr 26, 2024

Happy to see all that boilerplate and debugging done on the previous bot can be carried on here

Honestly a life saver, could probably not have bothered without already knowing the pit falls

although I'm probably not qualified to comment on the CI portion.

No worries, I also copied most of it from the previous CI flows in the fork (mostly done by Kyrluckechuck). If you want to talk/learn about it, you know which group to drop a message in :)

@akshualy akshualy merged commit 6fe95a5 into main Apr 26, 2024
4 checks passed
@akshualy akshualy deleted the create-executable branch April 26, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create executable with versions and releases
3 participants