-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create executable and do version checking #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Happy to see all that boilerplate and debugging done on the previous bot can be carried on here, though you added some much cleaner improvements 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the bot changes, although I'm probably not qualified to comment on the CI portion.
Honestly a life saver, could probably not have bothered without already knowing the pit falls
No worries, I also copied most of it from the previous CI flows in the fork (mostly done by Kyrluckechuck). If you want to talk/learn about it, you know which group to drop a message in :) |
Resolves #6
Code changes:
pyinstaller
to create a windows binary, including an icon filepip install .[dev]
logs
folder, up to 10 most recent logs are being kept thereSince we now keep logs, I decided against a "Press any key to continue" catch in the console. It was not as reliable as I wanted it to be.
Workflow changes:
pyproject.toml
version fieldREADME changes: