Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add on.push to clear warning from CodeQL #144

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

JustPyrrha
Copy link
Contributor

@JustPyrrha JustPyrrha commented Jul 21, 2021

I've noticed that when I setup CodeQL I didn't add the on.push trigger so every pr since then has had a warning such as:

1 issue was detected with this workflow: Please specify an on.push hook so that Code Scanning can compare pull requests against the state of the base branch.

This PR adds that trigger to fix the warning.

More work is needed to reduce the amount of runs. fixed with 168a6d1

Copy link
Member

@marcus8448 marcus8448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustPyrrha JustPyrrha merged commit 4cb9a5d into main Jul 21, 2021
@JustPyrrha JustPyrrha deleted the fix/codeql/clear-no-on-push-warning branch July 21, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants