update models of archgrey, grey, commetcube for animation #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustPyrrha
suggested changes
Dec 10, 2022
| public void setupAnim(T entity, float limbSwing, float limbSwingAmount, float ageInTicks, float netHeadYaw, float headPitch) { | ||
|
|
||
| public void setupAnim(T livingEntity, float limbSwing, float limbSwingAmount, float ageInTicks, float netHeadYaw, float headPitch) { | ||
| /*boolean bl = livingEntity.getFallFlyingTicks() > 4; |
There was a problem hiding this comment.
please dont leave commented out code in prs
Comment on lines
+35
to
50
| public class ArchGreyEntityModel<T extends ArchGreyEntity> extends EntityModel<T> { | ||
| private final ModelPart Body; | ||
| private final ModelPart Left_Arm; | ||
| private final ModelPart Right_Arm; | ||
| private final ModelPart Left_Leg; | ||
| private final ModelPart Right_Leg; | ||
| private final ModelPart Left_leg; | ||
| private final ModelPart Right_leg; | ||
| private final ModelPart Head; | ||
|
|
||
| public ArchGreyEntityModel(ModelPart root) { | ||
| this.Body = root.getChild("Body"); | ||
| this.Left_Arm = root.getChild("Left_Arm"); | ||
| this.Right_Arm = root.getChild("Right_Arm"); | ||
| this.Left_Leg = root.getChild("Left_Leg"); | ||
| this.Right_Leg = root.getChild("Right_Leg"); | ||
| this.Left_leg = root.getChild("Left_Leg"); | ||
| this.Right_leg = root.getChild("Right_Leg"); | ||
| this.Head = root.getChild("Head"); | ||
| } |
There was a problem hiding this comment.
whats with all the weird field names? is there some model json somewhere that needs them referenced like that or is it just someone before you having a pr accepted without actually following our standards?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.