New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PermutationImportance with XGBClassifier and pd.DataFrame issue#256 #261

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@harrysalmon

harrysalmon commented Apr 28, 2018

PermutationImportance.fit fails with XGBClassifier when passed a pandas Dataframe but fits when passed an numpy array.

A test for the error in #256 @ianozsvald

May also be related to general xgb >= 0.7 issue #259

@ianozsvald

This comment has been minimized.

ianozsvald commented Apr 29, 2018

Many thanks for the test @harrysalmon . To the core devs on ELI5 - this test is a result of a "Make your firsts open source contribution" that I co-ran at PyDataLondon 2018 yesterday. Cheers!

@lopuhin

This comment has been minimized.

Contributor

lopuhin commented May 3, 2018

Great, thanks a lot for contributing the test @harrysalmon and for finding the issue @ianozsvald !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment