Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "sudo: false" now that travis no longer supports it #17

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

lucywang000
Copy link
Contributor

No description provided.

@lucywang000
Copy link
Contributor Author

@lopuhin
Copy link
Contributor

lopuhin commented Dec 10, 2018

Looks like the build failure is due to an html-text update - TeamHG-Memex/html-text#15 - I didn't realise that this was a breaking change. html-text removed parsel dependency, but we need it, so now we need to add it to soft404 dependencies instead.

@codecov-io
Copy link

codecov-io commented Dec 13, 2018

Codecov Report

Merging #17 into master will decrease coverage by 2.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   92.77%   89.95%   -2.82%     
==========================================
  Files           5        5              
  Lines         249      249              
==========================================
- Hits          231      224       -7     
- Misses         18       25       +7
Impacted Files Coverage Δ
soft404/train.py 91.97% <0%> (-5.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ccc51...84b6b16. Read the comment docs.

@lucywang000
Copy link
Contributor Author

@lopuhin thanks for the guide, I have fixed it

Copy link
Contributor

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @lucywang000 , and thanks for fixing the build 👍

@lopuhin lopuhin merged commit c23c782 into TeamHG-Memex:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants