Merge pull request #7232 from TeamNewPipe/release/0.21.12

Fix check for new Version and release 0.21.12
TeamNewPipe · Oct 12, 2021 · 7eb13a9 · 7eb13a9
2 parents e0ba9b3 + 7c9896b
commit 7eb13a9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -17,8 +17,8 @@ android {
         resValue "string", "app_name", "NewPipe"
         minSdkVersion 19
         targetSdkVersion 29
-        versionCode 977
-        versionName "0.21.11"
+        versionCode 978
+        versionName "0.21.12"
 
         multiDexEnabled true
 

diff --git a/app/src/main/java/org/schabi/newpipe/App.java b/app/src/main/java/org/schabi/newpipe/App.java
@@ -43,8 +43,6 @@
 import io.reactivex.rxjava3.functions.Consumer;
 import io.reactivex.rxjava3.plugins.RxJavaPlugins;
 
-import static org.schabi.newpipe.CheckForNewAppVersion.startNewVersionCheckService;
-
 /*
  * Copyright (C) Hans-Christoph Steiner 2016 <hans@eds.org>
  * App.java is part of NewPipe.
@@ -113,9 +111,6 @@ public void onCreate() {
                 && prefs.getBoolean(getString(R.string.show_image_indicators_key), false));
 
         configureRxJavaErrorHandler();
-
-        // Check for new version
-        startNewVersionCheckService();
     }
 
     @Override

diff --git a/app/src/main/java/org/schabi/newpipe/MainActivity.java b/app/src/main/java/org/schabi/newpipe/MainActivity.java
@@ -20,6 +20,8 @@
 
 package org.schabi.newpipe;
 
+import static org.schabi.newpipe.CheckForNewAppVersion.startNewVersionCheckService;
+
 import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.Intent;
@@ -163,6 +165,9 @@ protected void onCreate(final Bundle savedInstanceState) {
             FocusOverlayView.setupFocusObserver(this);
         }
         openMiniPlayerUponPlayerStarted();
+
+        // Check for new version
+        startNewVersionCheckService();
     }
 
     private void setupDrawer() throws Exception {

diff --git a/fastlane/metadata/android/en-US/changelogs/978.txt b/fastlane/metadata/android/en-US/changelogs/978.txt
@@ -0,0 +1 @@
+Fixed executing the check for a new NewPipe version. This check was executed too early sometimes and therefore lead to an app crash. That should be fixed now.