Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queueing logic when queue is empty (bug?) #2611

Open
2 tasks done
opusforlife2 opened this issue Sep 9, 2019 · 2 comments
Open
2 tasks done

Queueing logic when queue is empty (bug?) #2611

opusforlife2 opened this issue Sep 9, 2019 · 2 comments
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) queue Issue is related to queueing

Comments

@opusforlife2
Copy link
Collaborator

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.

Long pressing on background/popup when the queue is empty adds the audio/video to the queue, but it also starts playing them, since they are the first entry. This is the same behavior as would arise when tapping on background/popup.

I propose that long presses should add to queue but keep it paused until the user plays it. Maybe it should start buffering meanwhile?

@Stypox Stypox added feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Oct 2, 2019
@opusforlife2
Copy link
Collaborator Author

@Stypox How difficult is this to implement? Could I try?

@Stypox
Copy link
Member

Stypox commented Jun 6, 2020

I think this is just a matter of changing startPaused to true when calling the function to open the player. See getPlayerIntent and getPlayerEnqueueIntent

@triallax triallax added the queue Issue is related to queueing label Nov 11, 2021
dtcxzyw added a commit to dtcxzyw/NewPipe that referenced this issue Apr 19, 2022
@dtcxzyw dtcxzyw mentioned this issue Apr 20, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) queue Issue is related to queueing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants