[unified player] everything crashes after playing a video on fullscreen

[panacist]

Version

-latest apk provided by B0pol

Steps to reproduce the bug

1. Go to any video
2. play on fullscreen
3. voice keeps playing for a while and the video stops
4. now every video on my phone can't be played for some reason

Expected behavior

should be playing normally as it does for the latest newpipe version

Actual behaviour

the app crashes and after forcing it to stop i no longer can play any video on my phone even from gallery [it may be something with my phone custom rom (RR Nougat) but it never happened this is the first time].
to fix the issue i just restart the phone

[avently]

Looks like you got a crash of your codecs. That's why you can't play any video. I don't think it's related to the unified player but to your custom OS.
And are you really think that with your steps to reproduce anyone can reproduce it? I mean, it's working fine for everyone because everyone uses fullscreen videos and could meet the crash already. So if you want help, try to isolate a problem and to give a really reproducible instructions.

No audio or video play back of any selected item, sent crash report via gmail

We have no access to mailbox you sent email to. Show the crash here

[wb9688]

@avently: Crash reports get imported into sentry.schabi.org (which I think you don't have access to), though there are a lot of incorrectly formatted e-mails (e.g. Gmail likes to insert line breaks and e.g. Outlook likes to add something like "Download Outlook for Android", which causes the JSON to be invalid) that won't be imported successfully. But even if it gets imported successfully, we can't know what crash report was sent by who (for privacy reasons), so we still don't know what crash report he refers to.

@panacist: A logcat would also be useful.

[opusforlife2]

Ah. Interesting. Try flashing a different build of your ROM, @panacist. Maybe that particular build has a bug.

@Kukulkan2019 Do you also have a custom ROM? You haven't given any details.

[avently]

@Kukulkan2019 you don't need a screenshot, you can just copy a text from crash report window and paste it here.

If the app is not working, I.e. you have crashes, it's not a problem to make a crash again and to send it's text here

[opusforlife2]

@Kukulkan2019

https://user-images.githubusercontent.com/17365767/81796016-24a30b80-950d-11ea-9b0d-a263b1932f53.png

See the bottom two buttons? Copy using that button, and paste the report here.

[panacist]

@opusforlife2 @avently @wb9688 yeah mine is probably due to the custom ROM and how it deals with codecs, same thing happens on replicant os whenever i play a video using the mpeg4 encoding

[avently]

@opusforlife2 so now you can attach screenshots, interesting:)

I mean you can select a text by long tapping on it, then press copy. Or attach screenshot from the start.
GaiException is a network problem, just for the info

[opusforlife2]

I lifted that from the PR that implemented those two buttons. 🤭

[avently]

@Kukulkan2019 just read it #4230 (comment)
And try to attach crash reports here.

[opusforlife2]

But even if it gets imported successfully, we can't know what crash report was sent by who (for privacy reasons), so we still don't know what crash report he refers to.

Did you read this? Your gmail crash reports will not help, which is why we're asking for the crash report here. I've given you a method to do it with an accompanying screenshot. Please do so.

@avently There's no need to be rude. If you get annoyed by something let someone else handle it.

[avently]

@opusforlife2

There's no need to be rude. If you get annoyed by something let someone else handle it.

Where I was rude?

[opusforlife2]

This #4230 (comment) wasn't called for.

[panacist]

@avently not rude but more like impatient and thinks like everyone should be familiar with the app i mean cool it down man and everything is gonna be alright :) !!
@Kukulkan2019 please be a bit understanding those guys aren't getting paid to serve ya or me so with just a bit of clarifications and help from your side they can fix it !

[avently]

It looks like a comedy show.
@panacist let us know if you have the same problems on another phone or stock-like OS.

I always use custom ROMs and know that problems with codecs happens often. So you just need to find a normal rom to be sure that the problem is with NewPipe.

[panacist]

@avently sure and i'll also test the app on replicant os but due to it's lack of any proprietary blobs i ain't sure enough wether the app will even function.
@Kukulkan2019 usually whenever i encounter a problem with the app i do this:
-make sure i am running the latest version
-look for any errors showing up on the screen
-clear data and cache and see if things can go back to normal
-check github issues to see if i have similar issue
-otherwise i open an issue and with plain simple english i try to describe the issue and how it happens usually in steps and include the error crash report (if any is avaible)
-and just wait for someone to notice the issue you know
please don't be angry and showing that on comments it won't do ya no good.
just because none can respond to your issue the way you want they are ignoring you. no they are usually trying to figure out what you mean so yeah and just because you are taking from your time to comment on this issue means you like the app and wants the best for it that's how i see it.

[opusforlife2]

I already tried to attach crash reports here, low memory on your end, I
also just uninstalled/reinstalled, still not working...

When do you get this error? When you tap on "Copy formatted report" from the screenshot I posted? Or when you tap "Report error on Github"? Or when you use the Share button at the top right?

[theScrabi]

@avently please be a bit more patient and calm. Please use "please" a bit more often. Some users might not know how things work. If you are patient and nice you will see they will be patient and nice with you to.

@Kukulkan2019 this is a community development. We don't get commercial support, yet we do the best we can. Please be aware that sometimes things might not work perfectly. However you are always welcome to support us either financially or by helping us getting rid of erros. Making NewPipe work is a task that involves all of us. You are currently not helping by blaming people. Either you communicate friendly and cooperative with us or you leave this discussion. I am willing to report you if this will not work one or another way!

[opusforlife2]

If you'll notice, the "unwarranted response" was minimized as well. Can you answer these #4230 (comment) questions instead of complaining?

[avently]

@theScrabi

please be a bit more patient and calm. Please use "please" a bit more often

I don't want to do something that I think is incorrect. You know, even if you written please multiple times it didn't stop that user to answer to you as he answered after your comment. Just read his message and you'll understand what i'm talking about.
please costs nothing most of the time. But what actually matters is an explanation. If the explanation didn't help, I don't care about the guy who ignores my explanation.

If you are patient and nice you will see they will be patient and nice with you to.

Most of the people in this issue were patient and nice and you see the result. So I can say that your thought is not always correct. That's why we should be flexible instead of kind.

Either you communicate friendly and cooperative with us or you leave this discussion. I am willing to report you if this will not work one or another way!

It's not a kind words but it's the right way to talk in the situation with this person.

I think we understand each other.

[opusforlife2]

I already tried to attach crash reports here, low memory on your end, I
also just uninstalled/reinstalled, still not working...

When do you get this error? When you tap on "Copy formatted report" from the screenshot I posted? Or when you tap "Report error on Github"? Or when you use the Share button at the top right?

I already told you, I always get the error, I'm done with you.

I gave you 3 options and you gave an ambiguous answer in return. If you're not going to be helpful, why are you here at all? Why even bother replying?

[panacist]

@opusforlife2 @avently i've tested the app using 4 different ROMs 2 of them are stockroms and two are custom roms and here are the results :
replicant os: everything crashes right after pressing on any video (doesn't happen with the current version).
RR os: crashes after tapping on the fullscreen icon.
android 5 (stockROM) : plays welll with a bit of gliching (not in a smooth way) before the video starts i bet it's due to playing the video on the notifications !! + when pressing the fullscreen icon a black screen is shown for a second or two while sound keeps playing.
android 4.4 (stockROM): same as android 5.
(a bad expirence is expected with low memory phones so if you have one please try it out yourself ! also i've spotted a few erros i'm going to open a new issue for them)

[avently]

@panacist can you just send a crashreport?

[panacist]

@avently when i said the app crashes i mean it literally crashes haha so no crash report is available ?

[panacist]

@avently it even forced my phone to restart on replicant os so dunno how am i supposed to get a crash report hmmm

[opusforlife2]

That's very odd. Even if the app crashes badly enough to take you to the home screen, it opens up the Error report activity right after.

[avently]

@panacist since you are a skilled guy can you take a logcat via adb and show the crash report from there?

You need to open a command line from your PC, connect a phone, type in terminal:
adb logcat
And send the output related to crash from NewPipe. You can also see the crash via app named Logcat reader (in Fdroid) (needs root) and copy from there

[panacist]

@avently sure thing i just didn't know a logcat would be helpful in that case but yeah gimme a few minutes

[panacist]

@avently
5 doesn't work it freezes the app once i click on the fullscreen icon and the funny thing is that it doesn't play video on fullscreen it just rotates the screen haha
4 same old things
3 my phone is restarting to test it

and i will certainly be late at work so i will try to test the 6 apk when i come late at night i dunno if you will be around or not

[panacist]

and once again thank you !!!!!

[avently]

Man, that's strange. I literally commened almost every piece of code that works between rotations.

and the funny thing is that it doesn't play video on fullscreen it just rotates the screen

That's ok. The main thing is to find what makes the freeze happening.

All in 6 + No saveCurrentAndRestoreDefaultBrightness, no setup brightness, no save/restore instance state, no fragment listener
7.zip

Actually I'm not sure what else I can remove. If non of the apks works, just send traces. Out of ideas without them.

[opusforlife2]

What happens when he presses the back button, though? The rotation part will be the same, but the video should pause. Whether that happens or not might give more insight, no?

[avently]

Whether that happens or not might give more insight, no?

No. In apks I sent the video already pauses but it doesn't help

[panacist]

@avently @opusforlife2 okay good news the 7 apk didn't cause the app to crash but when rotating the screen (autorotate enabled) a black screen on the video show up for 1 to 2 seconds before it starts playing(i suspect its due to proccessing power constraints haha) .
but two things :
first i don't think it is a codec issue but rather a format container issue because technically speaking i guess we can wrap any codec around any format without any problems.
second thing, if i can find you a free software that uses exoplayer and works fine should this be helpful to you to find the causes of this crash ?

and regarding the anr i think it is unlikley to happen if i don't press the screen Continuously in a response to the app being frozen so just waiting for that to pop up is kinda absurd.

[avently]

@panacist what about 6 apk?

[panacist]

@avently oops didn't test it wait a second please!

[panacist]

@avently crashes the app hahah

[avently]

actually 1 and 2 apks have the same code difference as 6 vs 7. So I wonder why 1 and 2 don't work for you

[panacist]

weird i will retest 2 and see again but 7 did actually play video

[panacist]

@avently working!! sorry i think it was a human mistake from my side,
but yeah working although i have to click play everytime i rotate the screen

[panacist]

@avently have you thought about the possibility that the player on the notifications is the problem try to get rid of it and see!? hahaha

[avently]

working!! sorry i think it was a human mistake from my side,

Man, please, test better next time. Two days just gone for nothing. Glad that I found the cause. Will post apk with actual fix.

although i have to click play everytime i rotate the screen

It will not be like that, just for quick testing

[panacist]

@avently sorry didn't mean to so what was the issue? not the codecs right?

[panacist]

@avently was going to forget thank you man !

[avently]

Of course not. If you have a working video in portrate, then nothing should stop you from viewing the same video in landscape:)
The problem is I saved into saveInstanceState the whole playQueue but KitKat have less space allowed for such data. On emulator it works fine but on some devices probably the allowed payload size is smaller and cause such behaviour. Fix is pretty simple so

[avently]

Also you may noticed that the problem with progress indicator is fixed too

[avently]

Right now I need to update my app in Google Play, after a couple of hours I upload apk with a fix here and maybe make a PR.

[panacist]

@avently yesterday i was listening to "stuck in the middle with you" while trying to fix the issue and thinking man we will never fix it, btw the chorus of the song goes something like this :
" clowns to the left of me (RR os )
jokers to the right (replicant os )
here i am stuck in the middle with you avently ahahah "
i recommend you listen to it too it's something from the 70's (back before the industry got sexualized and music bastardized).
@opusforlife2 thank you too for your help!

[avently]

Check this one. Is it work ok for you?

without-freeze.zip

P.S. comment number 100. Too much for one issue:)

[avently]

see #4272