Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls remain on screen after switching to fullscreen before video has loaded #4950

Open
4 tasks done
uusijani opened this issue Nov 21, 2020 · 5 comments
Open
4 tasks done
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@uusijani
Copy link

uusijani commented Nov 21, 2020

Checklist

  • I am using the latest version - v0.22.1
  • I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
  • I have read the contribution guidelines
  • This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

  1. Disable "Start main player in fullscreen" in NewPipe settings
  2. Have a somewhat slow-to-load video (for whatever reason)
  3. Open the video in Newpipe
  4. Before video details (such as duration) have loaded, tap to switch to fullscreen

Actual behaviour

The playback controls remain on screen while the video plays, I have to tap once more to make them go away.

Expected behavior

The playback controls should disappear like they do when switching to fullscreen after the video details have loaded (and playback has begun).

Screenshots/Screen recordings

fullscreen

Device info

  • Android version/Custom ROM version: Android 10 with OneUI 2.5
  • Device model: Samsung Galaxy Tab S5e
@uusijani uusijani added the bug Issue is related to a bug label Nov 21, 2020
@opusforlife2 opusforlife2 added the player Issues related to any player (main, popup and background) label Nov 21, 2020
@JCU0 JCU0 mentioned this issue Feb 15, 2021
3 tasks
@TacoTheDank
Copy link
Member

Hello, does this issue still occur on the latest version?

@uusijani
Copy link
Author

Hi @TacoTheDank! Yes, this is still reproducible with 0.22.1 and the steps above, plus a disabled "Start main player in fullscreen", which, if enabled, prevents the issue from triggering. (I'll edit the report to add this.)

I normally have that option enabled, so this usually doesn't affect me anymore, but it's still there.

@TacoTheDank
Copy link
Member

TacoTheDank commented Mar 30, 2022

Interesting... I also have a Samsung device running Android 10 with OneUI 2.5, however mine is a Note 9 (a phone). I am also unable to reproduce this behavior.

Even if they don't automatically disappear, are they at least dismissible with a touch?

This may be fixable with the planned player rewrite. We'll just have to see.

@uusijani
Copy link
Author

Yes, they're dismissible. They can even be brought back on after that (with another tap), and then they do disappear on their own.

I've updated Android on the tablet since reporting this, it's now running Android 11 with One UI 3.1, with no change in the behavior as reported.

I've also tested landscape, portrait and autorotate modes, all with the same result.

@Feuerswut
Copy link

Ah, yes, sometimes this still happens. Click twice and it should disappear normally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

4 participants