Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember step for playback speed controls #7031

Closed
Massimo-B opened this issue Aug 31, 2021 · 0 comments · Fixed by #7728
Closed

Remember step for playback speed controls #7031

Massimo-B opened this issue Aug 31, 2021 · 0 comments · Fixed by #7728
Labels
feature request Issue is related to a feature in the app template missing The bug/feature template is missing (e.g. the used app does not support issue templates)

Comments

@Massimo-B
Copy link

Massimo-B commented Aug 31, 2021 •
edited

Make playback the step width in percent a sticky option, which saves its last state. Usually it's always reset to 25% if you re-open the option dialog on the video screen.

I usually work with 1,15x average speed for speech channels and 5% step width, with the need to adjust according to content and situation, but I always need to adjust the width first, which is annoying.
@Massimo-B Massimo-B added the bug Issue is related to a bug label Aug 31, 2021
@Massimo-B Massimo-B changed the title Make playback step width sticky Remember step for playback speed controls Sep 2, 2021
ktprograms added a commit to ktprograms/NewPipe that referenced this issue Jan 31, 2022
@ktprograms
Remember adjustment step size for playback controls (speed and pitch)
6d40a63 
Save adjustmentStepSize to shared preferences, pass it back and forth
between PlaybackParameterDialog and Player/PlayQueueActivity.

Made DEFAULT_STEP in PlaybackParameterDialog public so it can be used as
the default adjustmentStepSize value in the Player.

Fixes TeamNewPipe#7031
@ktprograms ktprograms mentioned this issue Jan 31, 2022
Merged
5 tasks
@AudricV AudricV added the template ignored The user didn't follow the template/instructions (or removed them) label Jan 31, 2022
ktprograms added a commit to ktprograms/NewPipe that referenced this issue Mar 1, 2022
@ktprograms
Remember adjustment step size for playback controls (speed and pitch)
62c0e66 
- Add adjustment_step_key to settings_keys.xml to be used when
saving/loading the step size.
- Remove the global stepSize variable and the code that saves it to
outState/loads it from savedInstanceState because it's now saved to
Shared Preferences.
- Move initially setting step size to setupStepSizeSelector to be
consistent with the other view setup methods, using the value loaded
from Shared Preferences.
- Save the step size to Shared Preferences inside setStepSize.

Fixes: TeamNewPipe#7031
@SameenAhnaf SameenAhnaf added feature request Issue is related to a feature in the app template missing The bug/feature template is missing (e.g. the used app does not support issue templates) and removed bug Issue is related to a bug template ignored The user didn't follow the template/instructions (or removed them) labels Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app template missing The bug/feature template is missing (e.g. the used app does not support issue templates)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remember adjustment step size for playback controls (speed and pitch) ktprograms/NewPipe
3 participants
@Massimo-B @AudricV @SameenAhnaf