Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Chapters and Transcripts in video details tab #7375

Open
2 of 3 tasks
goyalyashpal opened this issue Nov 8, 2021 · 10 comments
Open
2 of 3 tasks

Show Chapters and Transcripts in video details tab #7375

goyalyashpal opened this issue Nov 8, 2021 · 10 comments
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@goyalyashpal
Copy link
Contributor

goyalyashpal commented Nov 8, 2021

Checklist

  • I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
    its prerequisities dont exist yet, so, there's not chance this issue's already open 😅 but still:
    🔍 merge chapters and subtitles
  • I have read the contribution guidelines given at CONTRIBUTING.md
  • This issue contains only one feature request. I will open one issue for every feature I want to request.
    This item unchecked as per @SameenAhnaf 's instruction at comment-976658910

What feature do you want?

In the video details tab:

  1. The available subtitles in the videos can be displayed
  2. Showing chapters in its own section can be helpful
  3. The channels and subtitles can then be merged in one view

Why do you want this feature?

  1. Showing all subtitles in one place helps a lot for accessibility:
    • for reading lyrics of songs #6661
    • for reading the course content
    • for skimming through video
  2. Merging subtitles and chapters will be super awesome, one case can be that the video is playing in tv, and this view on phone is serving as the presetation viewer - chapters being the slides, and subtitles being the material.

Updates:

  1. Go to this comment: comment-1073197615 for expansion on point 2.
    Go to this comment: comment-1073190990 for general mockups.

References:

  1. Softwares/services that already show subtitles in one place:

#### Depended on: #7373 #7374

@goyalyashpal goyalyashpal added the feature request Issue is related to a feature in the app label Nov 8, 2021
@triallax
Copy link
Contributor

Sorry, I'm having some trouble understanding what you're requesting. Can you clarify?

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Nov 23, 2021

I think, this issue asks for following layout as a tab in video details.

@yashpalgoyal1304 Could you please include all necessary information here and close #7373 & #7374 instead? Every single code will have to be rewritten if any dev doesn't work on these issues altogether. Also as @litetex and @mhmdanas stated, the actual purpose of this issue is really hard to understand.

@goyalyashpal

This comment was marked as resolved.

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Mar 20, 2022

So, two things: Container , and Contents

Container will have properties like:

  • Mode: Collapsed (default) /Expanded
  • Time : Visible (default) /Hidden
  • Long Press to select (∵ no links)
  • Share button (ref: yt site) would be redundant imo, thus not suggested
  • i thought about auto-expanding subtitles on pausing, but i am not sure about if it will be good or not.
  • There can also be option of having subtitles expanded by default in settings, so, smth like:
By default, expand subtitles: (o--)

Content:

  • the list of actual fetched data
  • two types of contents: chapters, transcriptions/subtitles
  • two status: current (highlighted) / passive
  • a single list item can span multiple lines,
    so, 2 line doesnt necessarily mean 2 items

The execution behaviour is that,

  • both these container lists (& corresponding highlight effect for active item) scroll in sync with video, and
  • the mockup made below will provide a sort of middle ground to give the feeling of link between a chapter, and its encompassing subtitle.

Chapter Subtitles
General Arrow at the top Arrow at the bottom
Collapsed 2 lines shown
No Thumbnail
3 lines shown
Expanded 6-8 lines? (4 in the mockup below)
Thumbnail shown (ref: yt desktop site)
Max 2 lines per item, ellipsize end of long chapters
5-10 lines?
Show at least one last line (or list item?)

Newpipe_Chapters-or-Subtitles


This following one i made earlier without thumbnails in the chapter's expanded container, but thumbnails feel like a novel item, and smth which the "refer to description for chapters" can't provide, so, i think they should be included if possible, and in low res:

Newpipe_Chapters-or-Subtitles

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Mar 20, 2022

I initially thought about these being side by side, rather than top-bottom (as in above), but as usual, "mobile" devices. So, u know.

Stretching the proposal:

Following is a far possibility, and i am not "pushing" for it. Just sharing it out
But these 2 containers CAN very well be placed side by side in landscape mode in tablets for example.
orrr.... even in mobile phone, but when video is telecast to some other screen.

In that case, the Chapter's container in collapsed mode will show only one item (not line), plus thumbnails as well,
and the subtitles will be shown usual. So, there, perfect combo (:

This was what i meant with the third point in the description

3. one case can be that the video is playing in tv, and this view on phone is serving as the presetation viewer - chapters being the slides, and subtitles being the material.

Shown below, video is casted to some other monitor, the newpipe on mobile is being used as above quoted

Newpipe_Chapters-or-Subtitles-tv

@goyalyashpal
Copy link
Contributor Author

i have done both the works remaining from my side, i hope it's a bit more clear now and makes some more sense 😅

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Mar 20, 2022

Wow, nice use of github bot to auto-covert markdown style image links to html style image links.

i suppose it's for use to change the height (as unique situation of newpipe - MOST ALL reports have huge screenshot images in them). ∴ makes sense too.

whoever did it, totally awesome work, impressive (:

@opusforlife2
Copy link
Collaborator

@litetex You're being praised. Come preen a little.

@ghost
Copy link

ghost commented May 2, 2022

I approve this enhancement.
Chapters on top of video player is very small & difficult to scroll. Having it's own tab beneath video helps us a lot.

@goyalyashpal goyalyashpal changed the title Show Chapters and Subtitles in video details tab Show Chapters and Transcript in video details tab Jun 1, 2022
@goyalyashpal goyalyashpal changed the title Show Chapters and Transcript in video details tab Show Chapters and Transcripts in video details tab Jun 1, 2022
@opusforlife2 opusforlife2 added discussion This needs to be discussed before anything is done GUI Issue is related to the graphical user interface labels Nov 12, 2022
@foxjaw
Copy link

foxjaw commented Dec 18, 2023

I approve this enhancement. Chapters on top of video player is very small & difficult to scroll. Having it's own tab beneath video helps us a lot.

Tbh I don't like any feature built inside player OSD apart from seeking & gestures.

Transcript saves millions of users time, promotes reading, saves tons of bandwidth & battery. Such a feature has to have it's own dedicated tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

5 participants