Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background player crashes if no internet available #947

Closed
2 tasks done
BeeeQueue opened this issue Dec 31, 2017 · 2 comments
Closed
2 tasks done

Background player crashes if no internet available #947

BeeeQueue opened this issue Dec 31, 2017 · 2 comments

Comments

@BeeeQueue
Copy link

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.

If the background player is playing a playlist and internet it lost the player attempts to play the next song, and proceeds to crash. In v11.0 it tried to play the next song and when it couldn't, it removed songs from the playlist in quick succession. Both seem unintentional and bad.

Reproduce by playing a playlist, then turn off Wi-Fi + mobile data.
karyogamy added a commit to karyogamy/NewPipe that referenced this issue Jan 4, 2018
@karyogamy
-[TeamNewPipe#947] Fixes player crashing on internet outage, issue pa…
4c06fdf 
…rtially addressed.
karyogamy added a commit to karyogamy/NewPipe that referenced this issue Jan 4, 2018
@karyogamy
-Added player conversion to background and popup players.
39b0b2f 
-[TeamNewPipe#919] Fixed custom notification does not trigger unlocking on lockscreen.
-[TeamNewPipe#947] Fixes player crashing on internet outage, issue partially addressed.
-Fixed main player losing state after destroy while in background.
-Fixed main player controls not hiding automatically after orientation change.
-Fixed dialog uploader not marqueeing when too long.
-Fixed popup permission throwing NPE on BaseList.
-Refactored popup permissions to start in NavigationHelper.
-Extracted hardcoded string for player menus.
-Bump Java version to 1.8.
-Some lambda conversions.
@karyogamy karyogamy mentioned this issue Jan 4, 2018
Merged
@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@BeeeQueue
Copy link
Author

Seems like it was fixed a while ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BeeeQueue