Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selecting image quality among multiple images #10062

Merged
merged 13 commits into from
Sep 22, 2023
Merged

Allow selecting image quality among multiple images #10062

merged 13 commits into from
Sep 22, 2023

Commits on Sep 22, 2023

  1. Support obtaining multiple images from the extractor

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    af23759 View commit details
    Browse the repository at this point in the history

  2. Add image quality preference

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0a8f28b View commit details
    Browse the repository at this point in the history

  3. Implement better image selection strategy

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    35073c7 View commit details
    Browse the repository at this point in the history

  4. Display all thumbnails in description tab

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4f7d206 View commit details
    Browse the repository at this point in the history

  5. Further improve image resolution strategy 

    Now using multiple comparison steps instead of magic values
    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    8d463b9 View commit details
    Browse the repository at this point in the history

  6. Add documentation and fix SonarCloud issue

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    bf908f0 View commit details
    Browse the repository at this point in the history

  7. Fix possible NPE in PlayQueueNavigator

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    37af2c8 View commit details
    Browse the repository at this point in the history

  8. Separate imageListToDbUrl from choosePreferredImage 

    imageListToDbUrl should be used if the URL is going to be saved to the database, to avoid saving nothing in case at the moment of saving the user preference is to not show images.
    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    87dca0f View commit details
    Browse the repository at this point in the history

  9. Fix loading images from db even if disabled

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0085ca6 View commit details
    Browse the repository at this point in the history

  10. Allow using CHECKSTYLE:OFF comments

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1b485dd View commit details
    Browse the repository at this point in the history

  11. Add test for ImageStrategy

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0a2d6d1 View commit details
    Browse the repository at this point in the history

  12. Use @DrawableRes in PicassoHelper

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    027b829 View commit details
    Browse the repository at this point in the history

  13. Make question mark localizable

    @Stypox
    Stypox committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f8b756c View commit details
    Browse the repository at this point in the history