Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidX Room library #10235

Merged
merged 2 commits into from Jul 18, 2023
Merged

Update AndroidX Room library #10235

merged 2 commits into from Jul 18, 2023

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fix MigrationTestHelper deprecation
  • Update AndroidX Room 2.4.3 -> 2.5.2 (changelog)

I had to cherry-pick my LeakCanary fix to test this, but I tested the feed, history, playlists, streams, and subscriptions, and everything works fine.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TacoTheDank TacoTheDank added the codequality Improvements to the codebase to improve the code quality label Jul 15, 2023
@TobiGr TobiGr added the dependency Issues and PRs related to dependencies label Jul 16, 2023
@TacoTheDank
Copy link
Member Author

Rebased for LeakCanary crash fix.

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TobiGr TobiGr merged commit cd2884d into TeamNewPipe:dev Jul 18, 2023
6 of 7 checks passed
@TacoTheDank TacoTheDank deleted the bumpRoom branch July 19, 2023 03:03
This was referenced Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality dependency Issues and PRs related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants