Adjust empty state message for ListInfoFragments depending on Info stream type #10304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ream type Show "no streams" for SoundClound. Show "no live streams" for MeidaCCCLiveStreamKiosk. Otherwise show "no videos"
TobiGr
added
bug
Stypox
requested changes
Aug 6, 2023
app/src/main/java/org/schabi/newpipe/fragments/list/BaseListInfoFragment.java
Outdated
Show resolved
Hide resolved
| super.showEmptyState(); | ||
| if (MediaCCCLiveStreamKiosk.KIOSK_ID.equals(currentInfo.getId()) | ||
| && ServiceList.MediaCCC.getServiceId() == currentInfo.getServiceId()) { | ||
| setEmptyStateMessage(R.string.no_live_streams); |
There was a problem hiding this comment.
This looks a bit difficult to maintain, but there is no better way atm I think. The optimal way would be for the extractor to announce what type of items a list will contain.
Stypox
approved these changes
Aug 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Screenshots
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence