Show indicator when loading download dialog #10407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishab247
changed the title
AudricV
added
feature request
6 tasks
TobiGr
requested changes
Sep 16, 2023
app/src/main/java/org/schabi/newpipe/download/LoadingDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/download/LoadingDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/download/LoadingDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/download/LoadingDialog.java
Outdated
Show resolved
Hide resolved
|
I applied some of my review comments and made the dialog's title customizable to allow using it in other part's of the app, too. |
TobiGr
force-pushed
the
feat/download_experence
branch
from
a66ce46
to
4e49992
Compare
rishab247
commented
Sep 17, 2023
There was a problem hiding this comment.
@TobiGr i am getting this error from CI Unknown failure: cmd: Failure calling service package: Broken pipe (32) this looks like a pipline issue as :app:connectedDebugAndroidTest working fine on my local. can you please rerun the pipeline
TobiGr
approved these changes
Sep 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
changed the title
This was referenced Oct 5, 2023
Merged
javulticat
pushed a commit
to NewPipeX/NewPipeX
that referenced
this pull request
Dec 30, 2023
* added LoadingDialog for improving download experience * [LoadingDialog] Apply some review comments and make title customizable. * removed permission handling from loading Dialog * fix checks * remove <p> Tag from first sentence --------- Co-authored-by: rishabaggarwal <Rishabaggarwal@sharechat.com> Co-authored-by: TobiGr <tobigr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Before:
Screen_recording_20230910_235412.webm
After:
Screen_recording_20230910_234930.webm
Fixes the following issue(s)
Preventing user from dropping out of the download flow while waiting for DownloadDialog to appear.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence