Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify selection of video stream #10730

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Commits on Jan 5, 2024

  1. Simplify selection of video stream

    I was trying to understand the logic here, and noticed the indirection
    via a QualityResolver interfaces is pretty unnecessary. Just branching
    directly makes the logic a lot easier to follow.
    
    The `-999` sentinel value is a bit dumb, but java does not recognize
    that videoIndex is always initialized.
    
    Nice side-effect, the `Resolver` interface was completely unused and
    can be dropped.
    Profpatsch committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    76eb751 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Configuration menu
    Copy the full SHA
    0148d65 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be4e0cb View commit details
    Browse the repository at this point in the history
  3. Remove null check on getDefaultSharedPreferences

    The function never returns `null`.
    Profpatsch committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    e5ac682 View commit details
    Browse the repository at this point in the history
  4. ListHelper: rename functions & variables and add documentation

    This should make the purpose of these functions more clear.
    Profpatsch committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    71d88d0 View commit details
    Browse the repository at this point in the history