Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store and reload the last used aspect ratio #1748

Merged
merged 3 commits into from Oct 6, 2018

Conversation

MaX-Lo
Copy link
Contributor

@MaX-Lo MaX-Lo commented Sep 22, 2018

The last used aspect ratio is now stored in SharedPreferences and gets reloaded when resuming the MainVideoPlayer Activity (similar to storing/reloading the last used screen rotation).

closes #1318

resuming the VideoPlayer Activity (similar to storing/reloading the last used: screen rotation)
@theScrabi
Copy link
Member

theScrabi commented Sep 23, 2018

@TobiGr or @karyogamy could you please QA this. Code looks fine so far.

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and code looks good 👍

@MaX-Lo MaX-Lo closed this Sep 29, 2018
@MaX-Lo MaX-Lo reopened this Sep 29, 2018
@theScrabi theScrabi merged commit 0e41310 into TeamNewPipe:dev Oct 6, 2018
@theScrabi theScrabi mentioned this pull request Oct 17, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Set Default Aspect Ratio
3 participants