fixes for #1759 #1944

kapodamy · 2018-12-14T18:14:00Z

Various fixes for #1759

add missing white icons and use hardcored way for change the icon colors
check if the iterator is initialized (fixes abnormal crash Newpipe 0.15.0 #2031)
allow retry downloads with "post-processing failed" error in the new muxer
new MPEG-4 muxer
misc clean-up ( by 167ad32)

Youtube fragments the audio stream into chunks of 10 seconds and the video stream into chunks of 3 seconds. As a result, the interleaving is not the same and causes an playback underrun.

The new "DASH-less" MP4 muxer fixes #2039, but requires the double of space. For example, if we download a file of 1.2GiB (1GiB video/200MiB audio), with the new muxer aditional 1.2GiB will be required to work.

[ ✔ ] I carefully read the contribution guidelines and agree to them.

TobiGr · 2018-12-14T23:41:09Z

Hey @kapodamy,
thanks for fixing the last small things!
After changing the orientation of the screen, I get the following exception:

Exception

User Action: ui error
Request: App crash, UI failure
Content Language: GB
Service: none
Version: 0.14.2
OS: Linux ,release-keys 6.0 - 23

Crash log

java.lang.ArrayIndexOutOfBoundsException: length=0; index=-1
	at java.util.ArrayList.get(ArrayList.java:310)
	at us.shandian.giga.service.DownloadManager$MissionIterator.getSpecialAtItem(DownloadManager.java:581)
	at us.shandian.giga.ui.adapter.MissionAdapter.setClearButton(MissionAdapter.java:533)
	at us.shandian.giga.ui.fragment.MissionsFragment.onPrepareOptionsMenu(MissionsFragment.java:159)
	at android.app.Fragment.performPrepareOptionsMenu(Fragment.java:2314)
	at android.app.FragmentManagerImpl.dispatchPrepareOptionsMenu(FragmentManager.java:2060)
	at android.app.FragmentController.dispatchPrepareOptionsMenu(FragmentController.java:277)
	at android.app.Activity.onPreparePanel(Activity.java:2869)
	at android.support.v4.app.FragmentActivity.onPrepareOptionsPanel(FragmentActivity.java:559)
	at android.support.v4.app.FragmentActivity.onPreparePanel(FragmentActivity.java:547)
	at android.support.v7.view.WindowCallbackWrapper.onPreparePanel(WindowCallbackWrapper.java:99)
	at android.support.v7.app.AppCompatDelegateImpl$AppCompatWindowCallback.onPreparePanel(AppCompatDelegateImpl.java:2576)
	at android.support.v7.view.WindowCallbackWrapper.onPreparePanel(WindowCallbackWrapper.java:99)
	at android.support.v7.app.ToolbarActionBar$ToolbarCallbackWrapper.onPreparePanel(ToolbarActionBar.java:522)
	at android.support.v7.app.ToolbarActionBar.populateOptionsMenu(ToolbarActionBar.java:456)
	at android.support.v7.app.ToolbarActionBar$1.run(ToolbarActionBar.java:56)
	at android.os.Handler.handleCallback(Handler.java:746)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:148)
	at android.app.ActivityThread.main(ActivityThread.java:5443)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

kapodamy · 2018-12-15T23:59:55Z

@TobiGr fixed with lastest commits (dc65cbe and be0abee)

TobiGr

Looks good. I'll wait for #1851 to be merged, to keep the number of merge conflicts as low as possible for @beNitinhere

ghost · 2019-01-10T20:40:54Z

I'm newbie but i want to help you in testing features.
@kapodamy @TobiGr I tested this change, in light theme icons in the download manager are white instead of black.
Like this:
#1759 (comment)

There is another UI issue in the download manager when downloading is finished, the line under the finished word is not correct from right side like on left side.

kapodamy · 2019-01-14T00:47:59Z

@FaizKhan5 the line under finished mimic the preferences screen group separator. ¿or is something related to RTL layouts?

ghost · 2019-01-14T03:10:27Z

Icons color are not black in light theme and group separator line is not same from both sides.

ghost · 2019-01-14T03:28:50Z

Another issue is that i tested several videos with those qualities which have no audio in previous versions and saw that there is sync issue of A/V. On some scene video still and audio playing and on some scene video playing and audio stop.

kapodamy · 2019-01-15T01:57:00Z

@FaizKhan5 works on my phone

also 844ed23 make the line """"""" simetric """"""

about the a/v desync if you use mx player choose HW/HW+ decoder. anyway, in any player use hardware decoding. These not are normal MP4 files, they are DASH MP4

TobiGr · 2019-01-15T10:15:38Z

It worked on my phone test devices with Android 5 and 6. @FaizKhan5 What device and Android version are you using? I am not sure if I tested Android 4.

ghost · 2019-01-15T15:29:17Z

I face issue of A/V desync only on VLC Android. Any solution? I don't want to use closed source apps like MX Player.

Same issue on HW in MX player, video only playing perfectly in SW/HW+.

@TobiGr please test videos with VLC and MX HW only

ghost · 2019-01-16T02:23:29Z

@kapodamy
Huawei Mate 10lite
Android : 8.0.0

Same UI issue on my device which i said previously. No changes in icon color and separate line with latest commits.

kapodamy · 2019-01-19T18:46:35Z

@FaizKhan5 please test again

ghost · 2019-01-19T19:45:20Z

@kapodamy Nothing change

ghost · 2019-01-22T09:51:36Z

@kapodamy Decrypt URL error on playing video in NP

kapodamy · 2019-01-22T19:25:29Z

@FaizKhan5 branch rebased

ghost · 2019-01-22T20:35:51Z

But it was fixed in 0.15.0 and you added those commits so why it has an issue?

* delete all grid.png files * delete all list.png files

* missing white icons * update attrs.xml and styles.xml

* hide clear button by default

* check if the iterator is initialized

make the separator line """"""""simetric""""""""""

* add null checks before resuming a download * (MissionAdapter.java) reset percent after resuming a download. prevents the "Error" string get stuck, until the download start

use another way to get the "Context"

work-around for reading the current theme icons

* allow retry downloads with "post-processing failed" error in the new muxer * MPEG-4 muxer ¡¡ no DASH output!! * keep the progress if download fails * remove TODO in SecondaryStreamHelper.java * misc clean-up * delete TestAlgo.java * delete ExtSDDownloadFailedActivity.java and remove it from AndroidManifest.xml * use hardcored version for changing icon colors

theScrabi · 2019-01-23T11:33:39Z

NewPipe-v0.15.1_fixed_download_preview.apk.zip

ghost · 2019-01-23T15:00:40Z

@kapodamy Thanks for fixing every issue.

kapodamy changed the title ~~add missing icons in download activity~~ add missing white icons in download activity Dec 14, 2018

TobiGr previously approved these changes Dec 21, 2018

View reviewed changes

kapodamy dismissed TobiGr’s stale review via 844ed23 January 15, 2019 01:54

kapodamy mentioned this pull request Jan 19, 2019

abnormal crash Newpipe 0.15.0 #2031

Closed

ghost mentioned this pull request Jan 20, 2019

v0.15.0 playback audio unsync #2039

Closed

kapodamy changed the title ~~add missing white icons in download activity~~ fixes for #1759 Jan 21, 2019

kapodamy mentioned this pull request Jan 22, 2019

Crashing issue during pause to start video downloading . #2049

Closed

kapodamy added 8 commits January 22, 2019 18:53

delete list and grid icons

6185c4d

* delete all grid.png files * delete all list.png files

add missing icons in bright theme

8d1d409

* missing white icons * update attrs.xml and styles.xml

Update download_menu.xml

ecabbb5

* hide clear button by default

Update MissionAdapter.java

8fed18b

* check if the iterator is initialized

Update missions_header.xml

df4dd01

make the separator line """"""""simetric""""""""""

misc fixes

c4a5e8d

* add null checks before resuming a download * (MissionAdapter.java) reset percent after resuming a download. prevents the "Error" string get stuck, until the download start

Update MissionsFragment.java

9db272f

use another way to get the "Context"

Update MissionsFragment.java

684cb81

work-around for reading the current theme icons

theScrabi merged commit f2285c0 into TeamNewPipe:dev Jan 23, 2019

kapodamy deleted the giga-postprocessing-iconfix branch January 25, 2019 02:03

This was referenced Jan 27, 2019

release v0.15.1 #2067

Merged

Release v0.15.1 #2068

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes for #1759 #1944

fixes for #1759 #1944

kapodamy commented Dec 14, 2018 •

edited

TobiGr commented Dec 14, 2018

kapodamy commented Dec 15, 2018 •

edited

TobiGr left a comment

ghost commented Jan 10, 2019 •

edited by ghost

kapodamy commented Jan 14, 2019

ghost commented Jan 14, 2019

ghost commented Jan 14, 2019

kapodamy commented Jan 15, 2019 •

edited

TobiGr commented Jan 15, 2019

ghost commented Jan 15, 2019 •

edited by ghost

ghost commented Jan 16, 2019

kapodamy commented Jan 19, 2019

ghost commented Jan 19, 2019

ghost commented Jan 22, 2019 •

edited by ghost

kapodamy commented Jan 22, 2019 •

edited

ghost commented Jan 22, 2019

theScrabi commented Jan 23, 2019

ghost commented Jan 23, 2019

fixes for #1759 #1944

fixes for #1759 #1944

Conversation

kapodamy commented Dec 14, 2018 • edited

TobiGr commented Dec 14, 2018

Exception

kapodamy commented Dec 15, 2018 • edited

TobiGr left a comment

Choose a reason for hiding this comment

ghost commented Jan 10, 2019 • edited by ghost

kapodamy commented Jan 14, 2019

ghost commented Jan 14, 2019

ghost commented Jan 14, 2019

kapodamy commented Jan 15, 2019 • edited

TobiGr commented Jan 15, 2019

ghost commented Jan 15, 2019 • edited by ghost

ghost commented Jan 16, 2019

kapodamy commented Jan 19, 2019

ghost commented Jan 19, 2019

ghost commented Jan 22, 2019 • edited by ghost

kapodamy commented Jan 22, 2019 • edited

ghost commented Jan 22, 2019

theScrabi commented Jan 23, 2019

ghost commented Jan 23, 2019

kapodamy commented Dec 14, 2018 •

edited

kapodamy commented Dec 15, 2018 •

edited

ghost commented Jan 10, 2019 •

edited by ghost

kapodamy commented Jan 15, 2019 •

edited

ghost commented Jan 15, 2019 •

edited by ghost

ghost commented Jan 22, 2019 •

edited by ghost

kapodamy commented Jan 22, 2019 •

edited