make links in comments clickable, increase text size #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theScrabi
requested changes
Mar 1, 2019
|
@theScrabi I have added handling for timestamp links in comments
|
3 tasks
theScrabi
approved these changes
Mar 3, 2019
3 tasks
nyanpasu64
added a commit
to nyanpasu64/NewPipeExtractor
that referenced
this pull request
Aug 18, 2019
For some reason, comments were handled in NewPipeExtractor as text, sent to NewPipe, and timestamps converted to hyperlinks using Linkify: TeamNewPipe/NewPipe#2168 On the other hand, video descriptions were handled in NewPipeExtractor as HTML. There, timestamp links were previously mangled (and now properly parsed), before being sent to NewPipe as HTML (where it's converted to Spanned).
nyanpasu64
added a commit
to nyanpasu64/NewPipeExtractor
that referenced
this pull request
Aug 18, 2019
For some reason, in NewPipeExtractor, comments were loaded from JSON by YoutubeCommentsInfoItemExtractor as text, sent via CommentsInfoItem#getCommentText to NewPipe, where timestamps are converted to hyperlinks using Linkify: TeamNewPipe/NewPipe#2168 On the other hand, video descriptions are handled in NewPipeExtractor by scraping the watch-page HTML. There, timestamp links were previously mangled (and now properly parsed), before being sent as HTML via YoutubeStreamExtractor#getDescription to NewPipe (where HTML gets converted to Spanned). The logic introduced in this commit is different from the above PR, since it operates in the extractor, and mutates the HTML DOM rather than identifying via regex.
nyanpasu64
added a commit
to nyanpasu64/NewPipeExtractor
that referenced
this pull request
Aug 18, 2019
For some reason, in NewPipeExtractor, comments were loaded from JSON by YoutubeCommentsInfoItemExtractor as text, sent via CommentsInfoItem#getCommentText to NewPipe, where timestamps are converted to hyperlinks using Linkify: TeamNewPipe/NewPipe#2168 On the other hand, video descriptions are handled in NewPipeExtractor by scraping the watch-page HTML. There, timestamp links were previously mangled (and now properly parsed), before being sent as HTML via YoutubeStreamExtractor#getDescription to NewPipe (where HTML gets converted to Spanned). The logic introduced in this commit is different from the above PR, since it operates in the extractor, and mutates the HTML DOM rather than identifying via regex.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires TeamNewPipe/NewPipeExtractor#144