-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add «Always expand description» in appearance settings, closes #1113 #2998
Conversation
Can you guys make it compatible with android 4.1.2? Please???😢😢😢 |
I just added a settings to automatically launch or not toggleTitleAndDescription function. So it will work on all devices since the toggleTitleAndDescription function already works on all devices. But if you wanna use NewPipe with android 4.1, look for NewPipe legacy |
Thank you so much!!! I love the app!!! More power to you guys...👍👍👍
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@B0pol could you provide a test apk? Code looks good to me ;-) |
a617628
to
0e1d9c7
Compare
autoExpandDescription.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The apk works correctly. Just a small thing ;-)
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
d3fec5c
to
cbb4d32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :-D
I am not sure if this setting is really needed. That feature request is 2 years old and received only 3 votes. |
Well, then remove from the projects issues you think unecessary, and also don't add the pr in milestones @TobiGr. |
Why not? More power to the user. |
Im okey with this project too. |
@B0pol sorry, my bad for adding it to Projects, apparently the feature is requested by a small number of people. Since this was added to the milestone I thought it was going to be merged, but I agree with @TobiGr |
@Stypox: I think that'd be OK, but only for really small things (i.e. low maintanance burden). I'm not sure if "Advanced settings" would be the correct name for it though. |
I don't think it's a good idea. Currently, settings are ok~ organized (why is main page content in appearance), so if you see the category, you'll know what it's about. If you put advanced settings, you will throw settings in it and it will be shambolic |
Or we could add a switch to enable advanced settings ("fine-tuning settings"?), just as in Android |
Advanced or 'Miscellaneous Settings' is a good option, I think. Newpipe isn't some critical application which will have planet destroying settings if the users don't know what they're doing. In the worst case, they'll disable comments or delete their main page tabs and be faced with the default blank page. I say let them mess with advanced settings at their own risk. Put it behind a Firefox about:config like warning. @B0pol Very good point. Main page content should be in Content. Edit: Actually, why can't this be the default state? Have the description always expanded. The user anyway has to scroll down for comments or suggested videos. It won't have any major impact. In fact, it might even lessen their distraction level. I know I've tapped on the first few suggested videos in a chain without watching any, once in a while. |
cbb4d32
to
85659e8
Compare
85659e8
to
ee3a65c
Compare
ee3a65c
to
2c9a6ad
Compare
Noooooooooooooooooo! |
what?
[image: Mailtrack]
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&>
Sender
notified by
Mailtrack
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&>
07/04/20,
19:54:22
Il giorno mar 7 apr 2020 alle ore 19:51 opusforlife2 <
notifications@github.com> ha scritto:
… Noooooooooooooooooo!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2998 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7TAVOMSTGCZGRGWOMV733RLNRZLANCNFSM4KLHGIZQ>
.
|
@B0pol why close? :( |
Because it was in 0.18.4 milestone, then 0.19.0, and not anymore in 0.19.3, and it has been pending for two months for a really small PR. Also, TobiGr has shown he's not really for it. |
Closes #1113
I added a switch in appearance settings for that, and the default value is false (stays as it's now).