New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification Improvements #3178
Merged
TobiGr
merged 29 commits into
TeamNewPipe:dev
from
cool-student:notificationImprovements
Sep 27, 2020
Merged
Notification Improvements #3178
TobiGr
merged 29 commits into
TeamNewPipe:dev
from
cool-student:notificationImprovements
Sep 27, 2020
Commits on Jul 31, 2020
-
- add MediaStyle notifications for Background and Popup playback - reduce excessive notification updating ( / recreating of Notification.Builder object) when playing background / popup media - add new buffering state indicator (can be disabled) - upscale close icon / downscale replay icon - add notification slot settings - move notification settings to appearance - fix Metadata (song title, artist and album art) sometimes not being set correctly - other misc notification fixes Co-authored-by: wb9688 <wb9688@users.noreply.github.com>
1Configuration menu - View commit details
-
Copy full SHA for 4abf6b2 - Browse repository at this point
Copy the full SHA 4abf6b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d499ff - Browse repository at this point
Copy the full SHA 7d499ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for caf7c55 - Browse repository at this point
Copy the full SHA caf7c55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6de03f2 - Browse repository at this point
Copy the full SHA 6de03f2View commit details
Commits on Aug 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 963ee4d - Browse repository at this point
Copy the full SHA 963ee4dView commit details
Commits on Aug 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1a8ff81 - Browse repository at this point
Copy the full SHA 1a8ff81View commit details
Commits on Aug 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for adef9a8 - Browse repository at this point
Copy the full SHA adef9a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e08480f - Browse repository at this point
Copy the full SHA e08480fView commit details
Commits on Sep 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c79997e - Browse repository at this point
Copy the full SHA c79997eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7766fd1 - Browse repository at this point
Copy the full SHA 7766fd1View commit details -
Various notification code improvements
Improve builder parameters Reorder code and extract large icon function service.startForeground() now is also provided with service type in android versions >= Q
Configuration menu - View commit details
-
Copy full SHA for 8b3a093 - Browse repository at this point
Copy the full SHA 8b3a093View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97ff9e9 - Browse repository at this point
Copy the full SHA 97ff9e9View commit details
Commits on Sep 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 628575d - Browse repository at this point
Copy the full SHA 628575dView commit details
Commits on Sep 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 408e819 - Browse repository at this point
Copy the full SHA 408e819View commit details
Commits on Sep 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 71b32fe - Browse repository at this point
Copy the full SHA 71b32feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cf0bc6 - Browse repository at this point
Copy the full SHA 9cf0bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc8954f - Browse repository at this point
Copy the full SHA bc8954fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd34c7e - Browse repository at this point
Copy the full SHA bd34c7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a13e6b6 - Browse repository at this point
Copy the full SHA a13e6b6View commit details
Commits on Sep 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1605e50 - Browse repository at this point
Copy the full SHA 1605e50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52e89c1 - Browse repository at this point
Copy the full SHA 52e89c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5846fba - Browse repository at this point
Copy the full SHA 5846fbaView commit details -
Fix seekbar invisible or not updating
Have the notification recreate only when strictly necessary, and recreate it if there was a timeline change, fixing the seekbar not updating at all sometimes
Configuration menu - View commit details
-
Copy full SHA for bccfe50 - Browse repository at this point
Copy the full SHA bccfe50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2017e6a - Browse repository at this point
Copy the full SHA 2017e6aView commit details
Commits on Sep 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 59e7eba - Browse repository at this point
Copy the full SHA 59e7ebaView commit details
Commits on Sep 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7317737 - Browse repository at this point
Copy the full SHA 7317737View commit details
Commits on Sep 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 11e048a - Browse repository at this point
Copy the full SHA 11e048aView commit details -
Remove ACTION_BUFFERING, update buffering only if needed
- ACTION_BUFFERING was just wrong: why should the user be able to trigger the internal onBuffering() state by pressing on the buffering button? So that was replaced by a null intent, doing nothing. - Now updating notification in onBuffering() only when buffering actions are not already buffering, to prevent useless updates
Configuration menu - View commit details
-
Copy full SHA for 814efbf - Browse repository at this point
Copy the full SHA 814efbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4e073c - Browse repository at this point
Copy the full SHA b4e073cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.