Fix url parsing from shared content #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, you're in form today! PR after PR. Anyway, I tried the apk and can confirm this is fixed. |
mauriciocolli
force-pushed
the
fix-url-parsing-share
branch
from
eb5769b
to
4dc2898
Compare
TobiGr
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Long description of the changes in your PR
Fix bug where urls from shared content were not being completed returned.
It happened when the app tried to find urls from the shared content and the url ended with one of the incorrectly considered "invalid" characters (e.g.
_).This is a pretty old issue, surprised that no one bumped into it in 3 years (!!!).
Fixes the following issue(s)
Fixes #3277
Testing APK
fix-url-parsing-share.apk.zip