Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support of playlist #377 (clone) #382

Merged
merged 25 commits into from Nov 25, 2016

Conversation

BlenderViking
Copy link

@BlenderViking BlenderViking commented Nov 25, 2016

StreamInfoItem:

  • Fix StreamInfoItem Layout (margin the three dots so they are in the right location)
  • make the StreamInfoItem button cover the whole Item not just the top (like it was before)
  • Remove the share and play option form the StreamInfoItem context menu
  • Make the StreamInfoItem context menu a local drop down menu (like the once of the download items)

stream-preview-info 2

stream-preview-info 3
stream-preview-info 1

Extractor:

  • Make the extractor part of the NewPipe extractor
  • Make the extractor fit the NewPipe architecture
  • Write unit tests for the extractor (can only be done before the first two parts are done)
    ChannelActivity:

Create a new layout for play list and queuing

  • Use the original layout for ChannelActivity again

Queuing- PlayListActivity:

Notification:

  • Make the rewind button, and the "last video button" be the same
    (if the music runs for more than 2 second rewind, if it runs longer go back to the last video)
  • Make, that the notification wont crash if there is no more video in the queue and someone hits the next/last button

I didn't find how to replace my previous pull request, so I created a new request :-/

Coffeemakr and others added 25 commits October 11, 2016 07:30
Currently translated at 100.0% (138 of 138 strings)
- Update android support lib
- Update the travis file
# Conflicts:
#	app/build.gradle
#	app/src/main/res/values-es/strings.xml
    - Fix StreamInfoItem Layout (margin the three dots so they are in the right location)
    - Make the StreamInfoItem button cover the whole Item not just the top (like it was before)
…german

Delete Swiss High German translation
      - Make the StreamInfoItem context menu a local drop down menu (like the once of the download items)
    - Fix StreamInfoItem Layout (margin the three dots so they are in the right location)
        - Fix Queue navigation (next and previous entries when on first and last item)
     - Persist on SQLite all change position item inside a playlist
       - Create a new layout / activity for local playlist and queuing
       - Code clean up
       - Create a new layout / activity for local playlist and queuing
       - Code clean up
       - Create a new layout / activity for external playlist
       - Restore original activity and layout for ChannelActivity
       -      Make the rewind button, and the "last video button" be the same (if the music runs for more than 2 second rewind, if it runs longer go back to the last video)
       - Fix random track on queue
       - Clean up
     - Create a floating button menu for process choice (Compatibility with device with lower SDK version at 14, thanks to project https://github.com/futuresimple/android-floating-action-button)
     - Create a floating button menu for process choice (Compatibility with device with lower SDK version at 14, thanks to project https://github.com/futuresimple/android-floating-action-button)
@theScrabi
Copy link
Member

Yep we are getting closer :) NNNNNNNNICE work

@theScrabi theScrabi merged commit 1b85046 into TeamNewPipe:playlist Nov 25, 2016
@BlenderViking BlenderViking deleted the playlist branch November 26, 2016 09:47
@BlenderViking
Copy link
Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants