Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.20.2 (956) #4675

Merged
merged 3 commits into from Oct 28, 2020
Merged

Release 0.20.2 (956) #4675

merged 3 commits into from Oct 28, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Oct 27, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Hotfix v0.20.2

TODO: update extractor version when #441 is merged

Fixes the following issue(s)

Relies on the following changes

APK testing

newpipe-HOTFIX.zip

Due diligence

@Stypox
Copy link
Member

Stypox commented Oct 27, 2020

This PR should go into master, shouldn't it, since it is a hotfix release?

@opusforlife2
Copy link
Collaborator

Yup. That's how it's usually done. And then master is merged into dev.

@Stypox
Copy link
Member

Stypox commented Oct 27, 2020

A hotfix allows work on the master branch instead of the dev branch.

https://teamnewpipe.github.io/documentation/05_releasing/

I'll take care of this

@B0pol
Copy link
Member Author

B0pol commented Oct 27, 2020

yes it should, my bad

@B0pol B0pol changed the base branch from dev to master October 27, 2020 18:56
@B0pol
Copy link
Member Author

B0pol commented Oct 27, 2020

done. It was already based on master, but by default it selected dev on github

TobiGr and others added 2 commits October 28, 2020 07:34
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
@TobiGr TobiGr merged commit 25d5551 into TeamNewPipe:master Oct 28, 2020
@falaafel
Copy link

Can someone give me steps to install the new version and to get it running nicely?

@B0pol B0pol deleted the hotfix branch October 28, 2020 10:47
@B0pol
Copy link
Member Author

B0pol commented Oct 28, 2020

@vkay94
Copy link
Contributor

vkay94 commented Oct 28, 2020

Does the current dev branch work for you? I've tried installing the original dev (after errors in rebased builds) but I get the "three attempts"-error again. I've noticed that the master branch has a different extractor version which works without problems.

@B0pol
Copy link
Member Author

B0pol commented Oct 28, 2020

No, it does not. master has not been merged into dev. To fix that, temporarily change NewpipeExtractor version in app/build.gradle to the latest commit hash here

@TobiGr @TheAssassin (maybe?) please merge master into dev and update extractor version

@vkay94
Copy link
Contributor

vkay94 commented Oct 28, 2020

@B0pol Yeah, I did that locally, I just though that the TeamNewPipe version in dev contains the fix since the hash now differs from before 😄

@Andre601
Copy link

Andre601 commented Oct 29, 2020

https://newpipe.schabi.org/blog/announcement/f-droid/pinned/f-droid-repo/

Doesn't really explain the actual updating process...
It says to deinstall newpipe to then update the source packages on F-Droid???

Edit: Had to install it from the F-Droid store again, this time with the new source. Works now. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants