Fix some things in ShareUtils file and do little improvements #5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangRongLin
added
bug
|
@Stypox I think this should be reviewed and merged before 0.20.9 release. |
|
Yes, I agree, I will add it to the TODOs |
TobiGr
reviewed
Jan 22, 2021
|
@TobiGr This should be resolved now. |
Fix a bug in which NewPipe doesn't fall back to Google Play Store web url in InstallApp Fusion getDefaultBrowserPackageName and getDefaultAppPackageName, rename openInDefaultApp to openAppChooser Update some JavaDocs
Stypox
approved these changes
Jan 30, 2021
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 21, 2021
…ements Fix some things in ShareUtils file and do little improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR fixes a bug that prevents NewPipe to fall back to Google Play Store URL when using InstallApp method. I also updated some JavaDocs and did little improvements. See commit for more details.
Due diligence