Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange libraries #5867

Merged
merged 2 commits into from Mar 31, 2021
Merged

Rearrange libraries #5867

merged 2 commits into from Mar 31, 2021

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

I hated having to try to read through the messy and unfiltered dependencies block whenever I would fork, so finally I figured I would do this (more for my own sake than anything 😅)

  • Update Android Studio to 4.1.3.
  • Rearrange dependencies block to look much nicer.
  • Also added little notes so people not familiar with the codebase will know what all the libraries are for without having to look them up.

APK testing

None needed.

Due diligence

@TacoTheDank
Copy link
Member Author

Will probably have to rebase this PR for #5856, or that PR for this one, but that won't be difficult to fix.

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

app/build.gradle Outdated Show resolved Hide resolved
@TacoTheDank
Copy link
Member Author

Finally got around to updating the PR, should be good now 👍

@TacoTheDank TacoTheDank requested a review from Stypox March 31, 2021 15:52
@Stypox Stypox merged commit 083c315 into TeamNewPipe:dev Mar 31, 2021
@Stypox
Copy link
Member

Stypox commented Mar 31, 2021

Thank you, looks good :-)

@TacoTheDank TacoTheDank deleted the rearrange-libraries branch March 31, 2021 16:20
This was referenced Apr 11, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants