Allow installation on external storage #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works (LG G5 android 8.0) recording_20210410_153334.1.mp4how to reproduce: |
|
@AlexN1997 that doesn't seem like an issue caused by my changes. Can you try out the latest development APK at the time and see if the bug is present there too? |
|
Its still here, so as you said, its not this PR causing the problem |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Allow installation on external storage.
Unfortunately, I'm not in possession of an external SD card, so I can't test this. Those who have SD cards, could you please test this?
Note that NewPipe uses
Services, which Android's docs state as one of the features that if present in an app, would mean that it shouldn't be allowed to be installed on external storage. I'm not sure if this means we shouldn't merge this PR, but I figured it would at least be relevant.Fixes the following issue(s)
APK testing
https://github.com/TeamNewPipe/NewPipe/suites/2463929014/artifacts/52944489
Due diligence