Make progress bars of watched streams filled #6310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triallax
commented
May 15, 2021
| @@ -65,8 +65,8 @@ public void setProgressTime(final long progressTime) { | |||
|
|
|||
| public boolean isValid(final int durationInSeconds) { | |||
| final int seconds = (int) TimeUnit.MILLISECONDS.toSeconds(progressTime); | |||
| return seconds > PLAYBACK_SAVE_THRESHOLD_START_SECONDS | |||
| && seconds < durationInSeconds - PLAYBACK_SAVE_THRESHOLD_END_SECONDS; | |||
| return (Math.abs(seconds - durationInSeconds) <= 1) || (seconds > PLAYBACK_SAVE_THRESHOLD_START_SECONDS | |||
There was a problem hiding this comment.
It's done like this since for some reason, the duration of a video appears to be rounded up from the actual duration (e.g. for a completed video with a length of 50 seconds, seconds might be 49).
triallax
added
bug
|
+100 actually came to make very same topic. either it's a bug or needs an improvement, but really uncomfortable to not understand if video was actually watched or i just clicked it and then skipped. |
|
@mhmdanas I'd just consider a |
|
Problem already solved, mysteriously. (dun dun duuuuuun) |
|
Yes, this was fixed in #3371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
When you finish a video and see it in your watch history, the red bar usually shown on the thumbnail is not present. The cause is that the player resets the watch progress of videos when they are done, so that when the video is played again it would start from the beginning. This PR instead saves the actual watch progress and then starts from the beginning in the player (still didn't figure out how to do this part).
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence