Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand minimized player buttons clickable area #7177

Merged
merged 2 commits into from Oct 1, 2021
Merged

Expand minimized player buttons clickable area #7177

merged 2 commits into from Oct 1, 2021

Conversation

tsiflimagas
Copy link
Contributor

@tsiflimagas tsiflimagas commented Sep 27, 2021 •
edited

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Enlarge the clickable area of the buttons in minimized player overlay, to match overlay's height and make the a bit wider to look proportionally good (I used a value which looked good to me for the width, opinions are needed).
  • Remove margins from buttons since they seemed of no purpose (please let me know if I'm wrong), and this way partially compensate for the width increase (2dp increase overall).

Before/After Screenshots/Screen Record

  • Before:
    Screenshot_20210923-123035012~01

  • After:
    Screenshot_20210923-1336058920101

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@tsiflimagas tsiflimagas changed the title Minimized player buttons clickable area Expand minimized player buttons clickable area Sep 27, 2021
@triallax triallax added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Sep 27, 2021
litetex
litetex approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 🎉
Code looks good and test was successful 👍

@litetex litetex merged commit 4ec5723 into TeamNewPipe:dev Oct 1, 2021
This was referenced Oct 2, 2021
Merged
Closed
@avently
Copy link
Contributor

avently commented Oct 3, 2021

Cool, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimized video overlay buttons clickable area
4 participants
@tsiflimagas @avently @litetex @triallax